GNOME Bugzilla – Bug 649909
merge System Monitor "System" tab into "Overview" tab, then suppress
Last modified: 2012-12-06 10:08:41 UTC
The general hw/sw information shown in System Monitor "System" tab should be merged into System info "Overview" tab in System Settings, since it's now duplicating the informations in two different, but similar, places. - The app will just focus on monitoring and caring about system state. - System Info will display its generic static system informations. - System monitor code will be easier to mantain. - could reuse the dropped code for System Settings on more thing: "Preferences" window should follow Gnome3 new "parented windows" policy (which I love). Hope you find it useful and agreeable. thanks you all! alex screenshot attached
(In reply to comment #0) > The general hw/sw information shown in System Monitor "System" tab should be > merged into System info "Overview" tab in System Settings, since it's now > duplicating the informations in two different, but similar, places. Yes, the information is very much duplicated. I don't quite understand what you want "merged" though - the only additional information I see in gnome-system-monitor is the kernel version (and I'm not sure it's that useful). So should this bug be reassigned to gnome-system-monitor as a request to remove the "System" tab? > screenshot attached Nope ;-)
I agree with the duplication, and as a possible solution see the removal of the System tab from gnome-system-monitor, as that's the only tab that doesn't monitor anything, just displays some information. Thinking even further, I could also imagine embedding the system monitor tabs into the System info applet, as system monitor is also showing system info, only it's not static, but dynamic.
uhm.. nothing happened here.. the bug on the System monitor side.. https://bugzilla.gnome.org/show_bug.cgi?id=649908 yes, I think the difference is between showing static/dynamic info
Confirming this, will prepare a set of patches with some minor improvements (worth adding here too) and will drop the system tab from system monitor.
Created attachment 230834 [details] [review] CPU model fix on arm The attached patch is a ported version of a system monitor commit [1] fixing system monitor bug #606769 (also present in control center due to the duplicated code for cpu detection based on cpuinfo), namely CPU model not being recognized on ARM. [1] http://git.gnome.org/browse/gnome-system-monitor/commit/?id=7a53cb935084d622187fb7054375ab3806ed7268
Created attachment 230835 [details] [review] PPC64 unknown model cpu fix This patch is a port of a gnome system monitor commit [1] fixing system monitor bug #619733 (but also present in control center due to the duplicated code for CPU model summarizing based on cpuinfo), namely an additional Unknown model CPU being added unnecessarily on PPC64. [1] http://git.gnome.org/browse/gnome-system-monitor/commit/?id=0b3770ba231b29793a0b231a39707f72a591b5df
Review of attachment 230834 [details] [review]: Prefix the subject line with "info: "
Review of attachment 230835 [details] [review]: Fine, don't forget about the "info: " prefix, and push to both gnome-3-6 and master. Those patches really should have gone in a separate bug though.
I have attached the patches here, as this bug report is already about removing the system tab from system monitor (and opened in control center), thus I thought they would fit here, and after these got pushed, we can close this as fixed, as there's not much else to do on the control center side (or did I misss something on this bug?). I only have commit rights to the system-monitor module, so would you please push the patches?
Created attachment 230877 [details] [review] CPU model fix on ARM Updated CPU model fix on ARM patch with the info: header in the subject.
Created attachment 230878 [details] [review] PPC64 unknown model CPU fix Unknown model CPU on PPC64 patch with info: added to the subject.