After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649305 - Incorrect filename after downloading an escaped URI
Incorrect filename after downloading an escaped URI
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Downloads
3.0.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-03 17:43 UTC by José María Casanova Crespo
Modified: 2011-06-10 16:08 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description José María Casanova Crespo 2011-05-03 17:43:58 UTC
When Epiphany downloads escaped URL with acutes the filename of the saved file is incorrect.

Steps to reproduce:

1. Write in the location bar the following URL : http://www.opidi.org/modules/Eventos/download.php?fichero=bolet%EDn%20de%20inscrici%F3n.doc&temp=1101-phpA1A.tmp
2. Check the downloaded filename.

Actual results:

The downloaded filename is : "download.php"

Expected results:

A file with the filename: "Boletín de inscripción.doc"

Does this happen every time?

Yes

Other information:

Other files in the same server but without escaped characters with the same mimetype work correctly, example:

http://www.opidi.org/modules/Eventos/download.php?fichero=Modelo%20-%20idea%20de%20proxecto.doc&temp=1101-phpA1B.tmp

The problem happened in Epiphany 3.0.1 under Fedora 15 Beta - 64bits
Comment 1 Dan Winship 2011-05-03 18:15:45 UTC
The server is returning

  Content-Disposition: filename="bolet�n de inscrici�n.doc"

ie, raw iso-8859-1. which, sigh, is technically allowed. (No other charset is.)

I forget, does epiphany use soup_headers_get_content_disposition() for this, or does it use some webkit stuff?
Comment 2 Sergio Villar 2011-05-06 16:52:47 UTC
It's working fine on master, so I guess something was not cherry picked when releasing.

Answering Dan, it indeed uses some webkit stuff. Check ResourceResponseSoup.cpp:84. It indeed takes the name from the filename of Content-Disposition.
Comment 3 Xan Lopez 2011-06-09 18:21:30 UTC
I still get "download.php" in master, so I don't think this is fixed.
Comment 4 Sergio Villar 2011-06-10 13:24:38 UTC
(In reply to comment #3)
> I still get "download.php" in master, so I don't think this is fixed.

Yes you were right. See https://bugs.webkit.org/show_bug.cgi?id=62454
Comment 5 Sergio Villar 2011-06-10 16:08:55 UTC
Closing as fixed as the patch in WebKitGtk+ have just landed.