After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648896 - Bad form of quantity in po file
Bad form of quantity in po file
Status: RESOLVED FIXED
Product: seahorse-plugins
Classification: Applications
Component: General
2.30.x
Other All
: Normal trivial
: 2.24
Assigned To: F Wolff
seahorse-plugins-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-28 20:06 UTC by Tomáš Virgl
Modified: 2011-08-31 15:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Suggested patch (1013 bytes, patch)
2011-08-31 09:32 UTC, F Wolff 		accepted-commit_now Details | Review

Description Tomáš Virgl 2011-04-28 20:06:59 UTC 
seahorse-plugins.master.pot:
#. should never be called for just one file
#: ../plugins/nautilus/seahorse-tool-files.c:346
#, c-format
msgid "You have selected %d files"
msgstr ""

should be in plural form because in e.g. slovak there is difference between form of 2 and 5.
Comment 1 F Wolff 2011-08-31 09:32:44 UTC 
Created attachment 195281 [details] [review]
Suggested patch

Here is a suggested patch. Ok to commit?
Comment 2 André Klapper 2011-08-31 09:50:55 UTC 
For the records (and developers that don't know):

https://live.gnome.org/TranslationProject/DevGuidelines/Plurals

stefw: Can this get a review in the next three days (String Freeze), please?
Comment 3 Tomáš Virgl 2011-08-31 10:36:33 UTC 
Yes, It is OK. Patch can be commited.
Comment 4 Stef Walter 2011-08-31 14:02:22 UTC 
Comment on attachment 195281 [details] [review]
Suggested patch

Please remove the assertion and on the line above.

Other than that, looks good, and can go in once the above change is made.
Comment 5 F Wolff 2011-08-31 14:49:46 UTC 
I pushed to git with 3d8c0236d8041499b96aaced61f71c3b7d895c08 with the assert removed. Thanks!
Comment 6 F Wolff 2011-08-31 15:02:28 UTC 
Oops, this broke the string freeze for GNOME 3.0 (master is still the branch for the frozen GNOME 3.0). Stef, what are the steps to add the branch retro-actively? Or would you prefer to do it?
Comment 7 Stef Walter 2011-08-31 15:20:05 UTC 
Whoops. Sorry bout that. Branch done.