After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648680 - Always send "Keep-Alive" header
Always send "Keep-Alive" header
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: HTTP Transport
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2011-04-26 16:35 UTC by Sergio Villar
Modified: 2011-04-26 17:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (3.82 KB, patch)
2011-04-26 17:05 UTC, Sergio Villar 		accepted-commit_now Details | Review

Description Sergio Villar 2011-04-26 16:35:48 UTC 
Our current approach of waiting for the server to tell us that is using HTTP1.0 does not improve performance as much as we would like because webpages use several different hosts to provide content, domain.com is served by a.domain.com, b.domain.com ....

By always adding the keep-alive header we will just be adding a bit more traffic but we'll get a lot reusable connections in return.
Comment 1 Sergio Villar 2011-04-26 17:05:19 UTC 
Created attachment 186671 [details] [review]
Patch
Comment 2 Dan Winship 2011-04-26 17:11:29 UTC 
Comment on attachment 186671 [details] [review]
Patch

>+	const gchar* conn_header;

oops, missed this before. "const char *conn_header;" (Not gchar, and put the * with the variable.)

good to commit with that change
Comment 3 Sergio Villar 2011-04-26 17:19:39 UTC 
Committed 8e99df80d27115a6afce4203ddcc9ce31c4a7ce6

Note to myself: do not let webkit naming conventions take over your brain