GNOME Bugzilla – Bug 648645
Notifications need ROLE_NOTIFICATION so that ATs can identify and present them
Last modified: 2012-03-10 01:16:55 UTC
Created attachment 186620 [details] test script Steps to reproduce: 1. Run the attached script. 2. Cause a notification (e.g. incoming chat message) to pop up in gnome-shell. Expected results: When the notification pops up, the associated accessible object (or a descendant thereof) contains the notification text. Actual results: When the notification pops up, it appears that neither it nor any of its descendants contains the notification text. Impact: ATs like Orca cannot present the notification messages that appear. ~~~~~~ For comparison/sanity check w.r.t. the test script, after pressing Alt+F1 I get the following: [canvas | Stage] [panel | ] All Accessories Games Graphics Internet Office Other Programming Sound & Video System Tools Universal Access Thus I think this might be specific to gnome-shell rather than a Clutter/Cally bug. CCing Piñeiro for assessment.
Created attachment 186622 [details] test script
After a quick skim on messageTray.js, Notification creates a StButton and then fill it with several other widgets, including some StLabel with the label and the text, and a StTable to organize it. StTable is a subclass of StContainer, and this one implements ClutterContainer, supported directly on CallyActor, so the full object hierarchy should be there, including the text objects. Anyway, I will review it. BTW, in the same way that you include the output when Alt+F1 is pressed, could you include the input when this notification appears?
(In reply to comment #2) > Anyway, I will review it. Thanks! > BTW, in the same way that you include the output when Alt+F1 is pressed, could > you include the input when this notification appears? [canvas | Stage] [panel | ] Event source has text: False
Today I tried this again, without doing anything extra (but with all the GNOME Shell related patches that I have in other bugs), opening gnome-control-center (so when it appears a "gnome-control-center notification) and I get this: [application | gnome-control-center] [layered pane | ] Event source has text: False [application | gnome-control-center] [frame | System Settings] Event source has text: False Appearance Keyboard Layout Language Support Online Accounts Screen Ubuntu One Personal Additional Drivers Bluetooth Color Displays Keyboard Mouse and Touchpad Network Power Printers Removable Media Sound Wacom Graphics Tablet Hardware Date and Time Software Sources System Info Universal Access User Accounts System [application | gnome-shell] [panel | ] Event source has text: False [application | gnome-shell] [panel | ] Event source has text: False System Settings 'System Settings' is ready So, can I assume that this specific issue is solved? Anyway, as you mentioned that the role was wrong, I will also set the role for the notification.
Created attachment 208058 [details] [review] Setting ATK_ROLE_NOTIFICATION for notifications
(In reply to comment #4) > Event source has text: False > System Settings > 'System Settings' is ready > > So, can I assume that this specific issue is solved? Just tried it with all your existing patches. I can confirm that the missing text issue (original, reported bug) has been solved... somewhere. :) > Anyway, as you mentioned that the role was wrong, I will also set the role for > the notification. Your patch in comment #5 works for me. Thanks!!
(In reply to comment #6) > (In reply to comment #4) > > > Event source has text: False > > System Settings > > 'System Settings' is ready > > > > So, can I assume that this specific issue is solved? > > Just tried it with all your existing patches. I can confirm that the missing > text issue (original, reported bug) has been solved... somewhere. :) > > > Anyway, as you mentioned that the role was wrong, I will also set the role for > > the notification. > > Your patch in comment #5 works for me. Thanks!! Ok, taking into account this comments, the only remaining thing to be done for notifications are the role, on comment 5. I will change the description of the bug to reflect this.
Because I was curious as to which of your patches solved the AtkText (originally reported problem), I reversed them all and just used your patch here, along with the patch from bug 667432 comment 6, and gnome-shell master. Apparently you already fixed the AtkText problem somewhere else. Nice!
(In reply to comment #6) > (In reply to comment #4) > > > Event source has text: False > > System Settings > > 'System Settings' is ready > > > > So, can I assume that this specific issue is solved? > > Just tried it with all your existing patches. I can confirm that the missing > text issue (original, reported bug) has been solved... somewhere. :) > > > Anyway, as you mentioned that the role was wrong, I will also set the role for > > the notification. > > Your patch in comment #5 works for me. Thanks!! Ok, taking into account this comment and comment 8, the only remaining thing to be done for notifications are the role, on comment 5. I will change the description of the bug to reflect this.
Commit 667432 is not still solved, but the commit that allowed to set roles is already committed. So I already committed the patch. Also closing the bug.