After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648555 - [regression] places-sidebar doesn't open selected item on enter
[regression] places-sidebar doesn't open selected item on enter
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Sidebar
3.0.x
Other Linux
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-24 13:57 UTC by Stefano Teso
Modified: 2011-04-25 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch against git master (4.43 KB, patch)
2011-04-24 13:57 UTC, Stefano Teso
committed Details | Review

Description Stefano Teso 2011-04-24 13:57:11 UTC
in bookmarks_key_press_event_cb () we use get_cursor () to open the current item; however, in the same function we use gtk_tree_selection_select_iter () to set it on up/down keypresses. these two calls don't play along: tree cursor != tree selection.

the attached patch fixes this issue by using gtk_tree_model_get_selection () instead.

(I'd rather not use _set_cursor () because AFAICS that would open the selected item when pressing up/down, which is quite annoying when moving through the sidebar with keynav only.)

please review.
Comment 1 Stefano Teso 2011-04-24 13:57:40 UTC
Created attachment 186554 [details] [review]
proposed patch against git master
Comment 2 Cosimo Cecchi 2011-04-25 17:47:36 UTC
Thanks for your patch Stefano, I pushed it to master so that it will be in today's 3.0.1 tarball.