GNOME Bugzilla – Bug 648188
Stop using time_t to store timestamps
Last modified: 2011-04-20 07:50:12 UTC
On bug #627726 Danielle wrote: """ At least one timestamp bug that I noticed. You should check varargs usage thoroughly for more, so we don't repeat the mistakes made in tp-logger. I strongly recommend porting all timestamps to gint64. """
Created attachment 186268 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/timestamp-648188 libempathy-gtk/empathy-chat-text-view.c | 41 ++++----- libempathy-gtk/empathy-chat-text-view.h | 2 +- libempathy-gtk/empathy-contact-widget.c | 6 +- libempathy-gtk/empathy-individual-widget.c | 6 +- libempathy-gtk/empathy-location-manager.c | 17 ++--- libempathy-gtk/empathy-theme-adium.c | 6 +- libempathy-gtk/empathy-theme-boxes.c | 2 +- libempathy/empathy-ft-handler.c | 4 +- libempathy/empathy-message.c | 18 ++--- libempathy/empathy-message.h | 2 +- libempathy/empathy-time.c | 122 ++++++++++----------------- libempathy/empathy-time.h | 10 +-- libempathy/empathy-tp-file.c | 2 +- src/empathy-map-view.c | 14 +++- 14 files changed, 105 insertions(+), 147 deletions(-)
Looks good.
Merged to master; thanks for the review. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.