After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647717 - Input source search box should use search and clear icons
Input source search box should use search and clear icons
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-13 21:33 UTC by Allan Day
Modified: 2011-04-26 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
region: Add "clear" secondary icon to search entry (2.93 KB, patch)
2011-04-26 13:39 UTC, Bastien Nocera
committed Details | Review

Description Allan Day 2011-04-13 21:33:24 UTC
The search box that is in the add input source (ie. keyboard layout) dialog is currently blank. It should follow the search box design pattern: edit-find-symbolic should be displayed in the right hand side of the text field, and this should switch to edit-clear-symbolic once a search has been entered in the box.
Comment 1 Sergey V. Udaltsov 2011-04-13 21:44:21 UTC
I am not sure I understand your idea. Could you illustrate please?
Comment 2 Allan Day 2011-04-13 22:07:37 UTC
The search box that is displayed in the all settings view provides a good example of what I mean. A search icon is displayed inside the text box, and this switches to a clear icon once some text has been entered.
Comment 3 Matthias Clasen 2011-04-14 11:29:06 UTC
Also compare bug 647685
Comment 4 Bastien Nocera 2011-04-14 12:47:15 UTC
Sergey, I'll do that when we branch for 3.2.
Comment 5 Sergey V. Udaltsov 2011-04-14 21:02:11 UTC
Allan: Yes, that would look nice
Bastien: Fair enough.
Comment 6 Bastien Nocera 2011-04-26 13:39:35 UTC
Created attachment 186651 [details] [review]
region: Add "clear" secondary icon to search entry
Comment 7 Bastien Nocera 2011-04-26 13:40:03 UTC
Attachment 186651 [details] pushed as 702fb77 - region: Add "clear" secondary icon to search entry