After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647516 - Try to differentiate between Gnash and proprietary Adobe Flash
Try to differentiate between Gnash and proprietary Adobe Flash
Status: RESOLVED DUPLICATE of bug 647096
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-12 01:01 UTC by Debarshi Ray
Modified: 2011-04-14 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed fix (1.20 KB, patch)
2011-04-12 01:03 UTC, Debarshi Ray
none Details | Review

Description Debarshi Ray 2011-04-12 01:01:35 UTC
Do not mistake Gnash as proprietary Adobe Flash and disable it. The Gnash binary is run out of process and uses XEmbed. Hence it does not matter from Epiphany's perspective what version of Gtk+ it uses.

There are various different ways to do this:
1. Check the libraries that the plugins link to.
2. Look for Gnash in the plugin's description.
3. Check the name of the shared object.

(1) won't work because the proprietary Adobe Flash uses dlopen to look for Gtk+ 2.x and then 1.x.

(3) won't work because I don't have a recent enough WebkitGtk+ with webkit_web_plugin_get_path, and I can not wait for a new release. :-)

(2) is what is proposed in https://bugzilla.mozilla.org/516166 The only problem is that people might change the description (can be done via an environment variable) to be an exact copy of Adobe's to satisfy stupid Flash detection scripts (http://cgit.freedesktop.org/swfdec/swfdec-mozilla/commit?id=2ff383). But then some of these stupid Web sites (eg., iMeem) are now dead.
Comment 1 Debarshi Ray 2011-04-12 01:03:55 UTC
Created attachment 185770 [details] [review]
Proposed fix
Comment 2 Gustavo Noronha (kov) 2011-04-12 11:17:38 UTC
I tried the GModule idea we were talking about, and it seems to work for me, here's the patch: https://bugs.webkit.org/show_bug.cgi?id=58297
Comment 3 Gustavo Noronha (kov) 2011-04-14 15:48:13 UTC

*** This bug has been marked as a duplicate of bug 647096 ***