After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647229 - Preferences window is empty/tiny
Preferences window is empty/tiny
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
3.0.x
Other Linux
: Normal normal
: 2.32
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-04-08 21:29 UTC by Gabriel Burt
Modified: 2011-04-16 01:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (811 bytes, image/png)
2011-04-08 21:29 UTC, Gabriel Burt 		  Details
Patch for fixing the issue (36.99 KB, patch)
2011-04-09 17:52 UTC, Rodrigo Duarte Sousa 		none Details | Review
Patch for fixing the issue (reupload) (1.67 KB, patch)
2011-04-10 17:23 UTC, Rodrigo Duarte Sousa 		committed Details | Review

Description Gabriel Burt 2011-04-08 21:29:38 UTC 
Created attachment 185554 [details]
screenshot

Every second or third time I try to open Preferences, it doesn't open right - it opens a new Gtk window, but it's empty/tiny.
Comment 1 Rodrigo Duarte Sousa 2011-04-08 22:48:34 UTC 
Here I was able to reproduce the bug:

Console output:

(cheese:18030): Gtk-CRITICAL **: gtk_container_set_border_width: assertion `GTK_IS_CONTAINER (container)' failed

(cheese:18030): Gtk-CRITICAL **: _gtk_box_get_spacing_set: assertion `GTK_IS_BOX (box)' failed

(cheese:18030): Gtk-CRITICAL **: gtk_box_set_spacing: assertion `GTK_IS_BOX (box)' failed

(cheese:18030): Gtk-CRITICAL **: _gtk_box_set_spacing_set: assertion `GTK_IS_BOX (box)' failed

(cheese:18030): Gtk-CRITICAL **: gtk_box_set_spacing: assertion `GTK_IS_BOX (box)' failed

(cheese:18030): Gtk-CRITICAL **: gtk_container_set_border_width: assertion `GTK_IS_CONTAINER (container)' failed

(cheese:18030): Gtk-CRITICAL **: gtk_container_foreach: assertion `GTK_IS_CONTAINER (container)' failed
Comment 2 Rodrigo Duarte Sousa 2011-04-09 06:53:05 UTC 
What I notice was that are two ways of closing the preferences window, the error doesn't happens when the user closes the window by clicking on "Close", but, when the window is closed by pressing Esc the next time the user try to open, the empty/tiny window shows up.
Comment 3 Rodrigo Duarte Sousa 2011-04-09 17:52:16 UTC 
Created attachment 185602 [details] [review]
Patch for fixing the issue

Pressing the escape key at the Preferences dialog closes it (and also deletes it internally), then, when the user tries to open it again an empty/tiny window shows up. The fix was handle the "delete-event" signal connecting it with "gtk_widget_hide_on_delete()". Now, press the escape key has the same effect that clicking on "Close" button.
Comment 4 Rodrigo Duarte Sousa 2011-04-09 18:19:38 UTC 
Also, the patch has a lot of changes at cheese-prefs.ui, due to a different version of Glade, maybe... The important part is only: <signal name="delete-event" handler="cheese_preferences_dialog_on_delete" swapped="no"/> inside the <object class="GtkDialog" id="cheese_prefs_dialog"> tag
Comment 5 Rodrigo Duarte Sousa 2011-04-10 17:23:51 UTC 
Created attachment 185653 [details] [review]
Patch for fixing the issue (reupload)

Reupload for the patch sent before, fixing the chesse-prefs.ui unecessary changes
Comment 6 Luciana Fujii 2011-04-16 01:31:37 UTC 
Review of attachment 185653 [details] [review]:

Thanks for the patch. Commited as 9c27753176e931908b894b6b3707a8588f9c1de5.