After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646934 - ShellStack: make this an StWidget
ShellStack: make this an StWidget
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-06 17:42 UTC by Dan Winship
Modified: 2011-09-08 12:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ShellStack: make this an StWidget (6.84 KB, patch)
2011-04-06 17:42 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2011-04-06 17:42:52 UTC 
I did this (in two pieces) as part of bug 646740, but then realized I
could just bypass the ShellStack there and so I didn't need this. But
here it is anyway... It presumably makes sense to do this at some point;
there aren't many non-StWidget actors left in Shell.
Comment 1 Dan Winship 2011-04-06 17:42:54 UTC 
Created attachment 185347 [details] [review]
ShellStack: make this an StWidget

Base ShellStack on StContainer rather than ClutterGroup, so that it
has StWidget-y features (and so we don't have to "cheat" in
shell_stack_allocate()). Implement navigate_focus() to only ever pass
focus into the top-most child, since doing otherwise would be
surprising.
Comment 2 Dan Winship 2011-05-16 10:33:22 UTC 
poke
Comment 3 Colin Walters 2011-05-16 18:56:55 UTC 
See also Jasper's work in https://bugzilla.gnome.org/show_bug.cgi?id=649631

Maybe make sense to try to use StLayoutContainer with ClutterBinLayout instead?
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-08-03 23:49:50 UTC 
Review of attachment 185347 [details] [review]:

Looks good.
Comment 5 Dan Winship 2011-09-08 12:52:58 UTC 
Attachment 185347 [details] pushed as 9ae8d90 - ShellStack: make this an StWidget