After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646887 - Crash when trying to show keyboard layout in fallback mode
Crash when trying to show keyboard layout in fallback mode
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: keyboard
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-06 05:31 UTC by Vincent Untz
Modified: 2011-04-06 12:40 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
keyboard: Fix crash on "Show layout" (1.92 KB, patch)
2011-04-06 05:40 UTC, Vincent Untz 		committed Details | Review

Description Vincent Untz 2011-04-06 05:31:41 UTC 
Program received signal SIGSEGV, Segmentation fault.
xkl_config_registry_find_object (config=0x0, 
    format=0xb3aed214 "/xkbConfigRegistry/layoutList/layout[configItem/name = '%s%s']", arg1=0xb3aebacf "", pitem=0x82583a8, pnode=0x0)
    at xklavier_config.c:386
386             if (!xkl_config_registry_is_initialized(config))
(gdb) bt

+ Trace 226608

  • #0 xkl_config_registry_find_object
    at xklavier_config.c line 386
  • #1 xkl_config_registry_find_layout
    at xklavier_config.c line 991
  • #2 gkbd_keyboard_drawing_dialog_set_group
    at gkbd-keyboard-drawing.c line 2669
  • #3 popup_menu_show_layout
    at gsd-keyboard-xkb.c line 178
  • #4 g_cclosure_marshal_VOID__VOID
    at gmarshal.c line 79
  • #5 g_closure_invoke
    at gclosure.c line 767
  • #6 signal_emit_unlocked_R
    at gsignal.c line 3252
  • #7 g_signal_emit_valist
    at gsignal.c line 2983
  • #8 g_signal_emit
    at gsignal.c line 3040
  • #9 gtk_widget_activate
    at gtkwidget.c line 6129 

The issue is that we pass a NULL registry to gkbd_keyboard_drawing_dialog_set_group().
Comment 1 Vincent Untz 2011-04-06 05:32:00 UTC 
Potential blocker for the release.
Comment 2 Vincent Untz 2011-04-06 05:40:35 UTC 
Created attachment 185259 [details] [review]
keyboard: Fix crash on "Show layout"

We need to make sure that we do have a xkl registry available.
Comment 3 Bastien Nocera 2011-04-06 11:48:47 UTC 
Looks fine to me.

Sergey?
Comment 4 Vincent Untz 2011-04-06 11:57:58 UTC 
FWIW, the release team would appreciate a 3.0.0.1 release with this fix (assuming the fix is fine according to maintainers) :-)
Comment 5 Sergey V. Udaltsov 2011-04-06 12:16:13 UTC 
Looks fine to me.
Comment 6 Vincent Untz 2011-04-06 12:40:51 UTC 
Comment on attachment 185259 [details] [review]
keyboard: Fix crash on "Show layout"

pushed