After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646675 - [patch] port EphyNetMonitor to GDBus
[patch] port EphyNetMonitor to GDBus
Status: RESOLVED DUPLICATE of bug 624421
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-04 01:37 UTC by Saleem Abdulrasool
Modified: 2011-05-07 21:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0002-ephy-port-net-monitor-to-GDBus.patch (14.33 KB, patch)
2011-04-04 01:38 UTC, Saleem Abdulrasool 		none Details | Review

Description Saleem Abdulrasool 2011-04-04 01:37:52 UTC 
Managed to split this out from the overall changes since it is isolated.  This patch changes EphyNetMonitor to use GDBus rather than dbus-glib.
Comment 1 Saleem Abdulrasool 2011-04-04 01:38:19 UTC 
Created attachment 185076 [details] [review]
0002-ephy-port-net-monitor-to-GDBus.patch
Comment 2 Xan Lopez 2011-04-04 03:00:58 UTC 
So, before reviewing this:

- As far as I know all this code does basically nothing at the moment, since WebKitGTK+ lacks a way of going into "offline mode".

- Porting stuff to GDBus is good, but porting dead code not so much.

- I think we can do three things:

  a) Since we don't use this, just kill it.
  b) Someone adds offline mode support into WebKitGTK+, and then it makes sense to do this.
  c) We can show the network status in the load-error pages (like Firefox or Chrome do, I think). We'll still have to wait for the timeout instead of failing immediately, but at least we can show the info there.

If someone does c) (should be easy), we can go ahead with this patch. b) should be done too, but it might require more work. Otherwise I'd go for a) for the time being.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2011-04-04 03:14:35 UTC 
I was working on this here:
https://bugzilla.gnome.org/show_bug.cgi?id=624421
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2011-05-07 21:22:56 UTC 
Thanks for the patch Saleem, however the previous bug (bug 624421) has an already cleaner patch.

Always remember to do a quick search in bugzilla for the issue you want to try to fix, you can use this query "product:epiphany <keyword for your bug>".

*** This bug has been marked as a duplicate of bug 624421 ***