After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646332 - FTBFS because of seed api change
FTBFS because of seed api change
Status: RESOLVED FIXED
Product: libpeas
Classification: Platform
Component: seed
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libpeas-maint
libpeas-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-31 13:12 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2011-04-01 05:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests/libpeas: fix extension-seed build (1.71 KB, patch)
2011-03-31 13:13 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review
Fix the seed plugin loader too (1.43 KB, patch)
2011-03-31 14:28 UTC, David King 		none Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2011-03-31 13:12:10 UTC 
attaching patch.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2011-03-31 13:13:10 UTC 
Created attachment 184776 [details] [review]
tests/libpeas: fix extension-seed build

Commit a655d0136520b156088327284c5a0377476008e7 in seed changed the
seed_*_value API.

Bug #646332
Comment 2 Ignacio Casal Quinteiro (nacho) 2011-03-31 14:10:46 UTC 
Review of attachment 184776 [details] [review]:

Looks good.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2011-03-31 14:16:59 UTC 
Attachment 184776 [details] pushed as 0c1f34b - tests/libpeas: fix extension-seed build
Comment 4 David King 2011-03-31 14:28:23 UTC 
Created attachment 184785 [details] [review]
Fix the seed plugin loader too

This builds fine if the symbol cannot be found (the symbol lookup is deferred until runtime), but then fails at runtime. Attached patch also replaces the symbol in the seed plugin loader.
Comment 5 Steve Frécinaux 2011-03-31 18:17:53 UTC 
the api change was actually triggered by us trying to expose a sane api in seed for our consumption. There is a patch ready which uses the new api and drops some more of our code. Maybe I should push it to master now the API we need is exposed from seed...
Comment 6 Steve Frécinaux 2011-03-31 18:30:24 UTC 
This is fixed in 2eba5fa63f41ad0b3ea12401e04bb44dad801ced.