After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646032 - logout dialog has an empty box when the user has no face image
logout dialog has an empty box when the user has no face image
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
[gnome3-important]
Depends on:
Blocks:
 
 
Reported: 2011-03-29 02:07 UTC by William Jon McCann
Modified: 2011-04-03 20:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
end-session-dialog: Hide icon if user icon is unset (1.28 KB, patch)
2011-03-29 14:38 UTC, Florian Müllner 		rejected Details | Review
end-session-dialog: Show default icon if user icon is unset (1.34 KB, patch)
2011-03-29 14:38 UTC, Florian Müllner 		committed Details | Review

Description William Jon McCann 2011-03-29 02:07:01 UTC 
The logout dialog has an empty box when the user has no face image.  This looks a bit strange.  Unfortunately the live images have no user face set by default.

Maybe we can just hide the box or something simple?
Comment 1 William Jon McCann 2011-03-29 02:08:25 UTC 
or maybe use avatar-default
Comment 2 Florian Müllner 2011-03-29 14:38:01 UTC 
Created attachment 184588 [details] [review]
end-session-dialog: Hide icon if user icon is unset

(In reply to comment #0)
> Maybe we can just hide the box or something simple?

If the user has not configured a user icon, the logout dialog will
display an empty rectangle. Hide the entire icon instead.
Comment 3 Florian Müllner 2011-03-29 14:38:26 UTC 
Created attachment 184589 [details] [review]
end-session-dialog: Show default icon if user icon is unset

(In reply to comment #1)
> or maybe use avatar-default

If the user has not configured a user icon, the logout dialog will
display an empty rectangle. Show a default picture instead.
Comment 4 Florian Müllner 2011-03-29 14:44:21 UTC 
Just a quick note to avoid confusion: the patches are exclusive :)
Comment 5 Matthias Clasen 2011-03-29 17:27:09 UTC 
We should definitively be consistent with what the user-account panel does, and show the avatar-default icon.
Comment 6 Florian Müllner 2011-03-29 17:32:04 UTC 
Comment on attachment 184588 [details] [review]
end-session-dialog: Hide icon if user icon is unset

(In reply to comment #5)
> We should definitively be consistent with what the user-account panel does, and
> show the avatar-default icon.

Sure.
Comment 7 Florian Müllner 2011-04-03 20:49:57 UTC 
Attachment 184589 [details] pushed as af69945 - end-session-dialog: Show default icon if user icon is unset