GNOME Bugzilla – Bug 646029
don't show "Disconnected" when cable is plugged in but device is off
Last modified: 2013-01-31 19:29:14 UTC
We shouldn't show "Disconnected" when a cable is plugged in but device is off. The term "connected" is a bit misleading. It is too close to unplugged. If there isn't any meaningful status I think just hiding the label is fine when the device is off.
Created attachment 234923 [details] [review] network: fix some translator comments They have to appear on the line immediately before the string or they won't get picked up.
Created attachment 234924 [details] [review] network: don't call inactive devices "Disconnected" It's confusing to call an ethernet device "disconnected" when it is plugged in but not in use. Just don't say anything instead. Also, update the icon logic to show the "disconnected" icon in this state, rather than the "connected" one, since it's confusing for the icon to change even though the network connection hasn't been activated.
Review of attachment 234923 [details] [review]: Looks good.
Review of attachment 234924 [details] [review]: Can we still show disconnected status, eg. not plugged in and not in use vs. plugged in but not in use? Otherwise the patch looks fine.
(In reply to comment #4) > Can we still show disconnected status, eg. not plugged in and not in use vs. > plugged in but not in use? Yes, not-plugged-in still shows as "Cable unplugged"
Attachment 234923 [details] pushed as 7b5ad4e - network: fix some translator comments Attachment 234924 [details] pushed as 534ad36 - network: don't call inactive devices "Disconnected"