GNOME Bugzilla – Bug 645981
issues with wireless expander in shell network widget
Last modified: 2011-04-11 14:44:39 UTC
1. Expander causes dropdown to change size (will attach video) 2. If the extra wireless networks go away, the 'More' expander is still shown, but the expander does nothing.
Screencast is at https://bugzilla.redhat.com/attachment.cgi?id=487568. Yay attachment limits.
the size-changing is fixed in git. (it still changes size, but it repositions the menu as well)
Created attachment 184497 [details] [review] NetworkMenu: destroy the More... submenu when empty Keep track of how many networks have been added to the more submenu, and destroy the menu when this number reaches 0.
Comment on attachment 184497 [details] [review] NetworkMenu: destroy the More... submenu when empty Hm... works, but it might be simpler to add a PopupMenuBase.length property and use that?
Created attachment 184499 [details] [review] NetworkMenu: destroy More... submenu when empty Add a .length property to PopupMenuBase, and use it from the network menu to destroy the menu when removing a network without rebuilding. I wanted the fix to remain self-contained, but this is definitely cleaner.
Comment on attachment 184499 [details] [review] NetworkMenu: destroy More... submenu when empty looks good
You mean: commit_after_freeze? Or you want a release-team exception? I don't think it is worth it, it can wait for 3.0.1.
Comment on attachment 184499 [details] [review] NetworkMenu: destroy More... submenu when empty oh, i thought you were planning to try to get it in. after freeze is better
ok, took a while to figure out how to test this. (I made NMDeviceWireless._createSection() set numItems to this._networks.length-1, and then unplugged my wifi hub.) It works.
Attachment 184499 [details] pushed as 625a4c0 - NetworkMenu: destroy More... submenu when empty