After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645949 - network: wireless list expands then shrinks again on first use
network: wireless list expands then shrinks again on first use
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 646001
 
 
Reported: 2011-03-28 14:24 UTC by Cosimo Cecchi
Modified: 2011-04-04 12:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix expand animation for submenus (1.13 KB, patch)
2011-03-31 19:53 UTC, Owen Taylor
committed Details | Review

Description Cosimo Cecchi 2011-03-28 14:24:38 UTC
It seems when I click on "More" in the wireless section for the first time, it is expanded to fill up the whole screen height, even if the list is shorter than that.
The visual effect is a sort of flicker, where the menu resizes to full height first and to the actual list height immediately after.
Comment 1 Giovanni Campagna 2011-03-28 15:27:05 UTC
Does it happen with e.g. bluetooth submenus?
(could be related to BoxPointer relayout code)
Comment 2 Cosimo Cecchi 2011-03-28 15:55:11 UTC
(In reply to comment #1)
> Does it happen with e.g. bluetooth submenus?
> (could be related to BoxPointer relayout code)

No, the bluetooth submenu works fine (but it has two lines instead of 10+ lines in the network menu).
Comment 3 Owen Taylor 2011-03-31 19:53:43 UTC
Created attachment 184815 [details] [review]
Fix expand animation for submenus

Figuring out the size of an unmapped actor is not completely
reliable because styles aren't fully assigned until an actor
is mapped. So show the submenu before computing the size we
want to tween to.
Comment 4 Owen Taylor 2011-03-31 20:05:02 UTC
See https://bugzilla.gnome.org/show_bug.cgi?id=632818#c5 for (most) of the root cause. I attached a patch there for StIcon that *almost* fixes the problem but still leaves the target size about 10 pixels off, probably because of some other style-changed handler. This patch is simpler and gives a fully correct result.
Comment 5 Dan Winship 2011-03-31 21:07:35 UTC
Comment on attachment 184815 [details] [review]
Fix expand animation for submenus

ok
Comment 6 Owen Taylor 2011-04-04 12:27:10 UTC
Pushed with r-t approval.

Attachment 184815 [details] pushed as 82e2ab8 - Fix expand animation for submenus