After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645901 - Fix include #config.h to make sure it's always the first include in the .c files
Fix include #config.h to make sure it's always the first include in the .c files
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-28 08:01 UTC by Kjartan Maraas
Modified: 2011-09-10 14:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to add missing include (3.58 KB, patch)
2011-03-28 08:01 UTC, Kjartan Maraas
committed Details | Review

Description Kjartan Maraas 2011-03-28 08:01:31 UTC
Created attachment 184420 [details] [review]
Patch to add missing include

Patch attached. Including config.h from a header makes it harder to keep control so just include it directly in the .c files instead.
Comment 1 Ross Burton 2011-03-28 09:41:22 UTC
Looks good, please commit.
Comment 2 Bastien Nocera 2011-03-28 09:46:34 UTC
*code freeze* break request first though.
Comment 3 Kjartan Maraas 2011-03-30 08:08:40 UTC
sound-juicer isn't in any jhbuild moduleset for 3.0 so I wonder whether code freeze still applies?
Comment 4 Bastien Nocera 2011-03-30 08:23:30 UTC
Code freeze does apply.