After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645842 - chart-only sheet actions
chart-only sheet actions
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Charting
git master
Other All
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2011-03-27 17:38 UTC by Andreas J. Guelzow
Modified: 2011-08-21 14:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (11.21 KB, patch)
2011-08-11 15:47 UTC, Jean Bréfort
committed Details | Review

Description Andreas J. Guelzow 2011-03-27 17:38:51 UTC
new gnumeric
insert chart
new graph sheet
insert

Note the "formula guru" button is still active (that's wrong).
and the undo button is active (that's right)

switch to Sheet1 and back to the chart-only sheet

buttons haven't changed (as expected).

undo
redo

you are back in the chart-only sheet but:
the "formula guru" button is now inactive (that's right).
and the undo button is also inactive (that's wrong)
Comment 1 Jean Bréfort 2011-03-28 06:58:25 UTC
Looks like the new graph is not selected when the sheet is created from the guru. After undo+redo, the graph is selected and that's why the buttons are disabled. Not sure that the undo and redo button should be enabled when a graph sheet is active since they are not when any sheet object is selected.
Comment 2 Jean Bréfort 2011-08-11 14:06:24 UTC
I think these actions should be enabled when a graph sheet is selected:

edit/undo
edit/redo
edit/sheet/*
view/new view
view/status bar
view/full screen
view/view properties
insert/sheet

Anything alse?
Comment 3 Jean Bréfort 2011-08-11 15:47:29 UTC
Created attachment 193645 [details] [review]
Proposed patch

Please review!
Comment 4 Morten Welinder 2011-08-11 19:14:39 UTC
Patch is probably ok, but the proliferation of action groups bothers me.
(It also bothers me in the current code.)
Comment 5 Jean Bréfort 2011-08-11 20:04:55 UTC
This is also my concern, but I don't see any better solution.
Comment 6 Jean Bréfort 2011-08-21 14:12:41 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.