GNOME Bugzilla – Bug 645753
Notifications for tray icons are lost
Last modified: 2011-03-29 03:13:09 UTC
NotificationDaemon associates received notifications with a tray icon, when it can find one, but the all tray icons forward clicks on the summary item to the X window. This means that notifications are not reachable from the summary, with either right or left click.
Created attachment 184295 [details] [review] MessageTray: don't forward click on sources with notifications When a source has an associated tray icon, we would forward all clicks to the X11 window, meaning that the summary notification could not be opened. Instead, restore normal event flow for clicks, when the source has notifications in the queue.
Giovanni - do you have an example of an app with both a tray icon and notifications? This issue was discussed earlier when the patch was going in and the feeling was that there weren't any important cases where this came up.
My case happened with liferea, which has the option to use a status icon and a notification at the same time. xchat-gnome has the same option available, although I disabled it. And even if there aren't important cases, a notification which exists but is impossible to interact with is at least a leak.
So, in the conflicting case, clearly either one or the other has to win. I don't see a problem with making the notifications win. *However* - I think we should restrict this to left-clicks, because the right-click menu is confusing and low-value for status icons and in fact reveals bugs - you can remove a status icon. Assigning for Dan to see if he sees any other issues with this approach and the interaction with forwarding clicks to status icons.
Comment on attachment 184295 [details] [review] MessageTray: don't forward click on sources with notifications general approach is fine. As Owen suggests, we may want to check the event button.
Created attachment 184492 [details] [review] MessageTray: don't forward click on sources with notifications When a source has an associated tray icon, we would forward all clicks to the X11 window, meaning that the summary notification could not be opened. Instead, restore normal event flow for clicks, when the source has notifications in the queue.
Comment on attachment 184492 [details] [review] MessageTray: don't forward click on sources with notifications looks good, subject to r-t approval
Pushed, thanks!. (Release-team sign-off: http://mail.gnome.org/archives/release-team/2011-March/msg00497.html) Attachment 184492 [details] pushed as 96c2b5e - MessageTray: don't forward click on sources with notifications