GNOME Bugzilla – Bug 645609
Give messages retrieved from the log a timestamp and a different style
Last modified: 2011-07-13 18:23:20 UTC
We need to indicate the messages that were retrieved from the log with a timestamp and possibly gray them out.
Created attachment 184240 [details] [review] telepathyClient: give a separate style to TpLogger messages Sometimes, log messages are hard to differentiate from normal, unread recent messages, so give a separate to messages retrieved from the TelepathyLogger service.
Created attachment 184241 [details] [review] telepathyClient: insert a timestamp between log messages and pending messages This will give a visual break, giving a bit of clarity when a message is received from a new contact.
Comment on attachment 184240 [details] [review] telepathyClient: give a separate style to TpLogger messages ok, so let's see if I find the same issues on the second review... >+.chat-log-message { would be better with a better name. ('log' does not necessarily suggest 'happened a long time ago'. I think I suggested chat-previous-session-message or something before, which is maybe too verbose.)
Comment on attachment 184241 [details] [review] telepathyClient: insert a timestamp between log messages and pending messages and this one does have the fix I mentioned before, and looks good
(oh, the graying-out patch is subject to design review...)
Comments on the timestamp part: * It is wrong to show a timestamp from months ago as having occurred "Tuesday" * They don't respect my preferred time format and are in 24h time * Today's messages say "Friday" when they could just say Today or just the time Specifically with respect to this but the first issue is quite bad.
OK, all these issues were pre-existing with the locality of timestamps. What should we do here? I don't think we want to anger the UI team with darkening, What about a blank space for separation?
One other thing on the timestamp patch: * It would be slightly better if the timestamp message had more space below than above it (just twice the existing padding perhaps) to make it more clear that it a) belongs to the message set above it b) that there was time between that set and "now" This should be a special case for stuff from the logs and not for every timestamp I think. For the dim patch: * I think it helps a bit * I think it makes sense to also dim the associated timestamp for the log Overall: * Both ideas seem worthwhile. * If possible with the changes requested
Created attachment 184509 [details] [review] telepathyClient: Do a better job with old chat timestamps Here's a patch to display better dates using an approach discussed on IRC: - steal date strings from calendar.js - use code adapted from http://git.fishsoup.net/cgit/splinter/tree/js/utils.js for picking which string to display. ==== If we have a date that's not within the last week, it's really confusing to display it as "Sent at 9:23 on Tuesday". Steal some t strings from calendar.js for displaying older dates to avoid a string-freeze break.
Review of attachment 184509 [details] [review]: Looks fine, nits ahead. Commit message: "Steal some t strings" ::: js/ui/telepathyClient.js @@ +469,3 @@ }, + _formatTimestamp: function(date) { Doesn't use "this", so it technically shouldn't be part of the prototype, but no harm done. @@ +491,3 @@ + } else { + /* Translators: Shown on calendar heading when selected day occurs on different year */ + format = (C_("calendar heading", "%A, %B %d, %Y")); Extra parens, inconsistent.
Pushed all three patches with the mentioned fixes to my patch and release-team approval. (http://mail.gnome.org/archives/release-team/2011-March/msg00501.html) Attachment 184240 [details] pushed as f117d9b - telepathyClient: give a separate style to TpLogger messages Attachment 184241 [details] pushed as b2a2a00 - telepathyClient: insert a timestamp between log messages and pending messages Attachment 184509 [details] pushed as b470736 - telepathyClient: Do a better job with old chat timestamps
// FIXME: The next two are stolen from calendar.js with the comment to avoid // a string-freeze break. They should be replaced with better strings // with 'Sent at', appropriate context and appropriate translator comment. What are some better strings, now that we're past freeze?