After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645547 - Constrain tooltips to monitors
Constrain tooltips to monitors
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-22 15:58 UTC by Owen Taylor
Modified: 2011-03-22 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
StTooltip: Add the ability to set a hook to constrain the tooltip (7.77 KB, patch)
2011-03-22 15:58 UTC, Owen Taylor
committed Details | Review
Constrain tooltips to monitors (2.50 KB, patch)
2011-03-22 15:58 UTC, Owen Taylor
committed Details | Review

Description Owen Taylor 2011-03-22 15:58:48 UTC
Here are patches so that the dash tooltips don't lap off the primary
monitor if the primary monitor is on the right.
Comment 1 Owen Taylor 2011-03-22 15:58:50 UTC
Created attachment 184089 [details] [review]
StTooltip: Add the ability to set a hook to constrain the tooltip

If, for example, the stage is divided into multiple monitors, we
might want to constrain tooltips so they don't cross monitor boundaries.
Add a function to set a per-stage callback to constrain tooltips.
Comment 2 Owen Taylor 2011-03-22 15:58:53 UTC
Created attachment 184090 [details] [review]
Constrain tooltips to monitors

Use st_tooltip_set_constrain_func() to set a function that constrains
tooltips to be on the same monitor as the original tip area.
Comment 3 Giovanni Campagna 2011-03-22 16:17:40 UTC
Review of attachment 184089 [details] [review]:

Ideally, we would use a ClutterConstraint here, but given that we're changing anchor-point instead of position, and given that JS cannot override virtual classes, I'd say this looks good to commit.
Comment 4 Giovanni Campagna 2011-03-22 16:22:26 UTC
Review of attachment 184090 [details] [review]:

Looks good!
Comment 5 Owen Taylor 2011-03-22 16:44:56 UTC
Attachment 184089 [details] pushed as d19cdc2 - StTooltip: Add the ability to set a hook to constrain the tooltip
Attachment 184090 [details] pushed as 80eb37e - Constrain tooltips to monitors