GNOME Bugzilla – Bug 644917
Restore missing mnemonics and fix menu entries
Last modified: 2011-03-17 10:14:34 UTC
Created attachment 183538 [details] [review] Proposed patch It seems recent changes in cheese removed some existing mnemnonics from menu items and changed others to non standard labels (for instance "Help Context" instead simple "Context" or Save As without ...) Here is a patch to fix those issues, adding missing _, changing other in order to use the proper mnemonic and fixing wrong labels. I'm going to ask a string freeze breakage too, in order to commit this on git ASAP (it should be a simple task for translators, mostly they have to restore previous translations)
Review of attachment 183538 [details] [review]: ::: data/cheese-actions.ui @@ +71,2 @@ <property name="stock_id">gtk-save-as</property> <signal name="activate" handler="cheese_main_window_on_file_save_as"/> I'd say just use the stock label here ? (although that is currently still '_Save As', without the ellipsis. @@ +105,3 @@ <object class="GtkToggleAction" id="fullscreen"> <property name="name">Fullscreen</property> + <property name="label" translatable="yes">_Fullscreen</property> This is the same as the stock label for GTK_STOCK_FULLSCREEN, so just use that, maybe ? @@ +216,3 @@ <object class="GtkAction" id="preferences"> <property name="name">Preferences</property> + <property name="label" translatable="yes">Prefere_nces</property> Again, could just use the stock label for GTK_STOCK_PREFERENCE here, though that is '_Preferences'
thanks a lot guys! luca, could you commit the patch integrating matthias review? not sure although, if you have to ask for a string freeze break here.
Created attachment 183548 [details] [review] Updated patch using "stock-id" Good catch, Matthias. I've updated the patch to directly use stock-id where applicable. This includes Open, Quit and Delete action. But I prefer to keep the custom label for "Save As". The scope was providing missing "..." and other applications are yet providing the sull "Save As..." (so translations are yet warned about it). Maybe could be interesting provide a way to automatically add "..." when needed. Something like a "require-user" GtkAction property that could add "..." when the action appears as menu entry or simple button and hide them when on toolbar or similar. So we can reuse more and more stock labels.
David, yes, we are in string freeze, but I've yet sent the break request :)
Committed, thanks.