After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644717 - Proxy settings tab not compliant with HIG
Proxy settings tab not compliant with HIG
Status: RESOLVED FIXED
Product: frogr
Classification: Other
Component: UI
master
Other Linux
: Normal normal
: ---
Assigned To: frogr maintainers
frogr maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-14 12:12 UTC by Łukasz Jernaś
Modified: 2011-03-14 12:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Left align labels in proxy settings tab (2.25 KB, patch)
2011-03-14 12:15 UTC, Łukasz Jernaś 		accepted-commit_now Details | Review

Description Łukasz Jernaś 2011-03-14 12:12:59 UTC 
The controls in the proxy settings tab look a bit out of place, the attached patch makes them compliant with the guidelines by left aligning the form fields
Comment 1 Łukasz Jernaś 2011-03-14 12:15:10 UTC 
Created attachment 183332 [details] [review]
Left align labels in proxy settings tab
Comment 2 Łukasz Jernaś 2011-03-14 12:16:09 UTC 
Forgot to include the relevant HIG entry: http://library.gnome.org/devel/hig-book/2.32/controls-entry.html.en
Comment 3 Mario Sánchez Prada 2011-03-14 12:29:19 UTC 
Review of attachment 183332 [details] [review]:

Looks good. Thanks for taking care of this.

Please feel free to commit when you wish.
Comment 4 Łukasz Jernaś 2011-03-14 12:52:51 UTC 
Thanks, pushed:

author	Łukasz Jernaś <deejay1@srem.org>	2011-03-14 12:13:01 (GMT)
committer	Łukasz Jernaś <deejay1@srem.org>	2011-03-14 12:13:01 (GMT)
commit	c1bc3bed9821c1f55f92946f29525ddcc4f69997 (patch)
tree	5e4c14db05457528016638f7422066d8ce809727
parent	35981f8a0843b18eefb9fe7ee81c17145e08226d (diff)
Left align the labels in proxy settings tab
This fixes https://bugzilla.gnome.org/show_bug.cgi?id=644717