After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644704 - [dvdsubedc] no SPU clipping implemented
[dvdsubedc] no SPU clipping implemented
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-14 09:57 UTC by Brendan Le Foll
Modified: 2011-03-14 17:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix clipping (2.68 KB, patch)
2011-03-14 09:57 UTC, Brendan Le Foll 		committed Details | Review

Description Brendan Le Foll 2011-03-14 09:57:37 UTC 
Created attachment 183321 [details] [review]
patch to fix clipping

dvdsubdec will garbage subtitles that are long and require clipping. The dvdspu element implements this and works well on the same video clips.

Here is a small git patch that changes how the values on SPU_SET_SIZE are calculated and added clipping code similar to dvdspu code in gst_dvd_sub_dec_merge_title.
Comment 1 Sebastian Dröge (slomo) 2011-03-14 17:41:46 UTC 
Thanks, but please use git format-patch style patches in the future :)

commit a72cc73798938a88c1da3a4d74d17eb2df7f6b02
Author: Brendan Le Foll <blefoll@fluendo.com>
Date:   Mon Mar 14 18:39:35 2011 +0100

    dvdsubdec: Implement clipping if the video size is smaller than the subpicture size
    
    Fixes bug #644704.