GNOME Bugzilla – Bug 644390
Reimplement timezone display
Last modified: 2014-11-07 14:58:36 UTC
I work with people from three different timezones so looking up what time it is at someone's place is quite frequent task for me. No need of fancy global map, just a line each zone would be enough.
*** Bug 648583 has been marked as a duplicate of this bug. ***
Relevant design page: http://live.gnome.org/GnomeShell/Design/Whiteboards/DateNTime
(In reply to comment #2) > Relevant design page: > > http://live.gnome.org/GnomeShell/Design/Whiteboards/DateNTime That's fine but this doesn't tell us where to get the data (=locations to display in the calednar dropdown). FWIW, I'd expect such data to be configured in https://live.gnome.org/Design/SystemSettings/DateAndTime And, FWIW, the date+time control panel still conflates locations with entries in the Olsson timezone database (which it also confusingly renders as Region/City)... in particular for the "show locations in calendar dropdown" feature discussed here you'd want the same fine-grained resolution as we had in GNOME 2. E.g. you want to be able to choose Boston, MA or Providence, RI and not having to chose New York, NY just because of how time-zones work on the technical level. Current behavior is tantamount to asking Londoners to choose "Frankfurt, DE" as their "Region/City"....
(In reply to comment #3) > Current behavior is tantamount to asking Londoners to choose "Frankfurt, > DE" as their "Region/City".... Uh? You made that up, didn't you? London and Frankfurt are in different timezones ;-)
(In reply to comment #4) > (In reply to comment #3) > > Current behavior is tantamount to asking Londoners to choose "Frankfurt, > > DE" as their "Region/City".... > > Uh? You made that up, didn't you? London and Frankfurt are in different > timezones ;-) Ugh, ignore that comment - I just looked up "tantamount" ...
(In reply to comment #4) > (In reply to comment #3) > > Current behavior is tantamount to asking Londoners to choose "Frankfurt, > > DE" as their "Region/City".... > > Uh? You made that up, didn't you? London and Frankfurt are in different > timezones ;-) Ah, yeah, except for that tiny detail.. :-) ... s/Londoners/Parisians/ then... my point was just that the entries in the Olsson database isn't very suitable for display to the end user. You only end up making people bitter about national / regional things or sports teams or stuff like that.
a) libgweather has abstractions for nicer (and translated) timezone names (which for most countries ends up just being the country name). The widget that exposes them (GWeatherTimezoneMenu) is unwieldy, but we can come up with something better. b) there is a Summer of Code student (Stéphane Maniaci) working on this this summer
Subscribing Stéphane. Here's the page for the GSoC project: https://live.gnome.org/freesteph_Libgweather_GnomeShell
*** Bug 658675 has been marked as a duplicate of this bug. ***
What is the situation with the GSoc now? I can't see updates on the given links
What is the status of this? Steph?
Hey! The status of my project is failed/stalled, because I couldn't figure out design plans and understand which directions to work. The code I had is a panel in the control-center that lets you add/remove locations, and then display them in the top panel of GNOME Shell. It's working, but it's very GNOME2-ish. There is no geo-detection from the network, or other "smart" features like we'd like to see in GNOME 3. I would really like to work on this and finish the feature for 3.4. I will try to poke the design team sometimes during the week.
How comes this is only labled an enhancement when, really, this is a clear regression from GNOME 2?
(In reply to comment #13) > How comes this is only labled an enhancement when, really, this is > a clear regression from GNOME 2? Because there is no plan to make GNOME3 provide all the features that GNOME2 had - Instead it's many of them, plus new and more important ones.
GNOME Clocks will provide a world clock function when it is released (probably with GNOME 3.6). We could show its world clocks in the calendar drop down...
(In reply to comment #15) > We could show its world clocks in the calendar drop down... Mockup!
(In reply to comment #16) > (In reply to comment #15) > > We could show its world clocks in the calendar drop down... > > Mockup! It'd be the same as the existing mockup [1] but with 'Clocks' instead of 'Change Locations >'. My only concern with this is that the calendar could get very tall. [1] http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/date-n-time.png
*** Bug 683313 has been marked as a duplicate of this bug. ***
Now that the Clocks application is coming along, couldn't we just add a « Open Clocks » entry above/below the « Open Calendar » one? This would keep the GNOME Shell time/calendar menu simple and clean (and prevent it from growing outrageously if I have many clocks for many locations), but still make it easy to get to all my clocks.
*** Bug 674099 has been marked as a duplicate of this bug. ***
Yes, we should add "Open Clocks"
Created attachment 228615 [details] [review] dateMenu: Add "Open Clocks" entry
Created attachment 228616 [details] How it looks I added the entry the same way the « Open Calendar » is added. It looks quite bad I think, but I'd rather have designer input than try to do something only half better myself. :)
*** Bug 687916 has been marked as a duplicate of this bug. ***
(In reply to comment #23) > Created an attachment (id=228616) [details] > How it looks > > I added the entry the same way the « Open Calendar » is added. > > It looks quite bad I think, but I'd rather have designer input than try to do > something only half better myself. :) Thanks for working on this, Mathieu! I'd suggest adding the clocks item to the other pane, above "Date and Time Settings". (We might be hiding the events pane in some situations.)
Created attachment 228874 [details] [review] dateMenu: Add "Open Clocks" entry
Created attachment 228875 [details] How it looks This is how it looks with the new patch, based on Allan's suggestion. Should it be placed above or below the « Date and Time Settings » entry? Should there be an additional separator between it and the calendar widget?
(In reply to comment #27) > Created an attachment (id=228875) [details] > How it looks > > This is how it looks with the new patch, based on Allan's suggestion. This doesn't reimplement the timezone display though. It basically gives you a link to open another application. It's not very helpful like the old implementation. If I have a meeting scheduled on one timezone or I need to call someone on another timezone and I want to quickly check what the time is in Perth when I'm in Helsinki I don't want to have to wait for an entire new app to open, interrupt my workflow only to have to quit it seconds later.
Created attachment 228879 [details] [review] dateMenu: Add "Open Clocks" entry Moved the entry below the separator, as Allan suggested in #gnome-design
Created attachment 228881 [details] How it looks New screenshot with the latest patch.
Of course there are various logic to read this dialogue. For one of them, you may consider aligning "Open Clocks" and "Open Calendar" | | | | Date and time sett. | | | | | | Open Clocks | Open Calendar | +-------------------------+-------------------------+ it would ease to reach the button "Open Clocks", which should be a significantly more frequent use case than "Date and time settings" and maybe move settings under a Settings icon | | | | | | | | | | Open Clocks | Open Calendar (*)| +-------------------------+-------------------------+ a suggestion
The settings menuitem is supposed to be at the very bottom to parallel the other status menus, which all have a settings menuitem at the bottom.
(In reply to comment #30) > Created an attachment (id=228881) [details] > How it looks > > New screenshot with the latest patch. Sorry Mathieu, I dropped the ball on this one. My suggestion would be to put all the "open" menu items in the left-hand pane, since having two items on one side and one on the other will look unbalanced. | | | | Open Calendar | | | | | | Open Clocks | | | | | | Date and Time Settings | | +-------------------------+-------------------------+ This approach will also mean that the calendar will still be accessible after bug 680083 is resolved.
There's a separator currently between the calendar and the « Date and Time Settings » entry. Should that separator now be between the calendar and the « Open Calendar » entry? Should there be other separators? (e.g between « Open Clocks » and « Date and Time Settings »)
(In reply to comment #34) ... I'd keep the single separator between the three menu items and the calendar grid: | | | | | | +---------------------+ | | | | | | --------------------- | | | | | | Open Calendar | | | | | | Open Clocks | | | | | | Date and Time Settings | | +-------------------------+-------------------------+
Created attachment 231617 [details] [review] dateMenu: Add "Open Clocks" entry This implements the changes requested by Allan in comment 35.
That's in fact great news! I am working constantly with people in four/five time zones and this feature was badly missing since the introduction of Gnome 3. I am glad that it will be back. Will it be integrated in Gnome 3.8? I hope so?!?
I think the concern in comment #28 is still valid. Is it decided to drop the extra clocks in calendar panel?
Review of attachment 231617 [details] [review]: source ::: js/ui/dateMenu.js @@ +101,3 @@ + this._openClocksItem.connect('activate', Lang.bind(this, this._onOpenClocksActivate)); + this._openClocksItem.actor.can_focus = false; + Given that gnome-clocks is not a core application, it would be very nice if you checked for its existence and hide the launcher if not installed. Otherwise, you need to check for the return value of lookup_app and show a failure notification.
Created attachment 231937 [details] [review] dateMenu: Add "Open Clocks" entry (In reply to comment #39) > Review of attachment 231617 [details] [review]: > Given that gnome-clocks is not a core application, it would be very nice if you > checked for its existence and hide the launcher if not installed. New patch does that. Was that the right way to check for it?
Review of attachment 231937 [details] [review]: source ::: js/ui/dateMenu.js @@ +98,3 @@ + this._calendarSettingsChanged(); + + this._openCalendarItem.actor.can_focus = false; This is the right way to check if an application exists, but it doesn't work if you install gnome-clocks, until the next logout. You need to connect to installed-changed, and check again.
Created attachment 232097 [details] [review] dateMenu: Move the "Open Calendar" entry This is the part of the previous patch which moves the « Open Calendar » item. I thought separating it to its own patch would make the review easier. (at least it made further changes of the rest easier for me)
Created attachment 232098 [details] [review] dateMenu: Add "Open Clocks" entry (In reply to comment #41) > This is the right way to check if an application exists, but it doesn't work if > you install gnome-clocks, until the next logout. > You need to connect to installed-changed, and check again. This is done with this version of the patch. It also removes the « Open Clocks » entry if gnome-clocks is uninstalled.
Review of attachment 232097 [details] [review]: Looks OK to me
Review of attachment 232098 [details] [review]: OK.
Created attachment 233561 [details] [review] [PATCH 1/2] dateMenu: Move the "Open Calendar" entry The previous two patches didn't apply on master any more, so I'm rebasing them.
Created attachment 233562 [details] [review] dateMenu: Add "Open Clocks" entry As for the other patch, this is just a rebase on master.
Patches pushed on behalf of Mathieu Bridon.
I think we've taken this as far as we can for now. We might re-examine in the future, but we don't need the bug report for that.