After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644041 - [patch] Use the correct application icon in the .desktop file
[patch] Use the correct application icon in the .desktop file
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
: 645837 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-03-06 21:08 UTC by Christopher Aillon
Modified: 2011-04-14 23:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix (708 bytes, patch)
2011-03-06 21:08 UTC, Christopher Aillon 		none Details | Review
Patch to rename files (6.30 KB, patch)
2011-03-06 22:46 UTC, Christopher Aillon 		none Details | Review
Oops, forgot to include an icon file (6.65 KB, patch)
2011-03-06 22:56 UTC, Christopher Aillon 		none Details | Review

Description Christopher Aillon 2011-03-06 21:08:56 UTC 
Created attachment 182635 [details] [review]
Patch to fix

Else, it shows up with no icon in GNOME Shell (and presumably the fallback menus, too).
Comment 1 Tristan Van Berkom 2011-03-06 21:56:30 UTC 
Hmmm, I changed that, the icon name should be 'glade' not 'glade-3'
for Glade 3.10 (glade master targeting GTK+ 3.0)

Glade 3.8 (parallel installable) is still called 'glade-3'.

What I changed the name of the data/glade-3.ico to
be glade.ico and changed the string in the .desktop.in file
to refer to the icon with the correct new name.

What else do I have to do to make sure that the 'glade' icon
is installed properly ?
Comment 2 Christopher Aillon 2011-03-06 22:33:06 UTC 
.ico files are not supported so you'd need to use either a PNG, SVG, or XPM.

The glade-3 icon was actually using the png/svg files under data/icons/hicolor so you could alternatively rename those to simply glade.{png,svg}
Comment 3 Christopher Aillon 2011-03-06 22:46:04 UTC 
Created attachment 182640 [details] [review]
Patch to rename files
Comment 4 Christopher Aillon 2011-03-06 22:56:34 UTC 
Created attachment 182642 [details] [review]
Oops, forgot to include an icon file
Comment 5 Tristan Van Berkom 2011-03-07 00:15:48 UTC 
Thanks, can you add an entry to the ChangeLog and commit that ?
Comment 6 Christopher Aillon 2011-03-07 02:15:25 UTC 
Sure...  pushed as a50330d59ae91ba2f734680941a43623006c0efa
Comment 7 Christopher Aillon 2011-04-14 23:06:20 UTC 
*** Bug 645837 has been marked as a duplicate of this bug. ***