GNOME Bugzilla – Bug 643977
Adwaita themed close button
Last modified: 2011-03-07 15:26:54 UTC
Created attachment 182580 [details] [review] original close button design The close button for windows in the overview has stronger resemblence to Mac OS X than the native Adwaita theme for GNOME 3.0. The attached patch addresses it. This was the original design for the window picker (although the window frame styling didn't come to be for 3.0): http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/overview-window-picker-6-workspaces.png
Review of attachment 182580 [details] [review]: (splinter fails on me, so not commenting inline - sorry for the inconvenience) I know it's ugly, but the actual size of the button is defined in the CSS. So the change to the image's size does not have any effect unless you change the CSS as well (style class is .window-close). It would be good to add a body to the commit message (the first paragraph of the bug description sounds good), and there's a small typo in the subject line ("teh").
(In reply to comment #1) > Review of attachment 182580 [details] [review]: > > (splinter fails on me, so not commenting inline - sorry for the inconvenience) This is https://bugzilla.mozilla.org/show_bug.cgi?id=635417 - you can use a webkit based browser like epiphany until we get a fixed Firefox in rawhide.
Created attachment 182701 [details] [review] updated style After discussing with mccann on IRC, here's an updated patch that keeps the dark shell style.
Review of attachment 182701 [details] [review]: Good, except for the commit message - not sure whether a body is required for that change, but the bug number should not be in the summary, but rather as full URL on its own line.
Thumbs up. Would be good to get this in.
Pushed attachment 182701 [details] [review] with a proper bug reference.