After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643812 - session: use full charset for RTSP session ID
session: use full charset for RTSP session ID
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal enhancement
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-03 19:37 UTC by Miguel Angel Cabrera Moya
Modified: 2013-10-30 21:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix for the bug report (1.52 KB, patch)
2011-03-03 19:40 UTC, Miguel Angel Cabrera Moya 		committed Details | Review

Description Miguel Angel Cabrera Moya 2011-03-03 19:37:26 UTC 
As specified in RFC 2326 section 3.4 use full valid charset to make guessing session ID more difficult.
Comment 1 Miguel Angel Cabrera Moya 2011-03-03 19:40:40 UTC 
Created attachment 182393 [details] [review]
Fix for the bug report
Comment 2 Tim-Philipp Müller 2011-03-04 09:09:58 UTC 
I was wondering if there's an off-by-one at the end, but it turns out g_random_int(a,b) returns something within the range [a;b[ , so there's a buglet in the current code :)
Comment 3 Wim Taymans 2011-03-07 18:43:08 UTC 
commit 17ce0df09a22966fe4298dab3eec384df3792192
Author: Miguel Angel Cabrera Moya <madmac2501@gmail.com>
Date:   Thu Mar 3 20:38:03 2011 +0100

    session: use full charset for RTSP session ID
    
    As specified in RFC 2326 section 3.4 use full valid charset to make guessing
    session ID more difficult.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=643812
Comment 4 christian 2013-10-19 02:50:48 UTC 
I know this is fairly old, but according to the RFC the characters need to be URI encoded. 

While VLC doesn't seem to care, ffmpeg hangs during the SETUP if the session ID contains either the $ or the +.
Comment 5 Sebastian Dröge (slomo) 2013-10-30 21:18:06 UTC 
commit 935e8f852d050b4939f1d0f44b38e9b55a2fbe36
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Wed Oct 30 22:16:54 2013 +0100

    rtsp-session-pool: Make sure session IDs are properly URI-escaped
    
    https://bugzilla.gnome.org/show_bug.cgi?id=643812