GNOME Bugzilla – Bug 643768
st-entry: Support a different color for selected text
Last modified: 2013-11-10 00:09:25 UTC
Requires Clutter patches from http://bugzilla.clutter-project.org/show_bug.cgi?id=2595 The CSS changes are temporary, I didn't get them from the mockups.
Created attachment 182331 [details] [review] Fix build for gcc 4.6 warnings for Clutter 1.7.
Created attachment 182332 [details] [review] st-entry: Support a different color for selected text This should improve readability in text entries where the text color is very close to the color of the selection.
Created attachment 182333 [details] [review] theme: Add selected text color This should improve readability of text that's selected.
Note that we can't use Clutter 1.7 branch changes until after GNOME 3.0 is out, so anything that requires new Clutter API can't go in at this point.
Review of attachment 182331 [details] [review]: Not going to take this until http://bugzilla.clutter-project.org/show_bug.cgi?id=2598 is fixed in Clutter, it's impossible to know if these changes are correct without knowing the usage pattern that is expected.
Comment on attachment 182331 [details] [review] Fix build for gcc 4.6 warnings for Clutter 1.7. Different fixes ended up getting pushed for clutter_init() changes - see bug 643910
*** Bug 615731 has been marked as a duplicate of this bug. ***
Looks like clutter bug 2598 is fixed now.
(In reply to comment #8) > Looks like clutter bug 2598 is fixed now. Should we start migrating to Clutter master, or wait until 1.7/1.8 is released?
Created attachment 191201 [details] [review] theme: Add selected text color This should improve readability of text that's selected. Rebase testing theme patch.
*** Bug 654160 has been marked as a duplicate of this bug. ***
Comment on attachment 182332 [details] [review] st-entry: Support a different color for selected text works
Comment on attachment 191201 [details] [review] theme: Add selected text color can you fix up lg too? ok to commit with that
Created attachment 191568 [details] [review] theme: Add selected text color This should improve readability of text that's selected. OK, used .lt-dialog StEntry instead.
Created attachment 191569 [details] [review] st-entry: Inherit all colors This is optional. Do we want to do this?
Comment on attachment 191569 [details] [review] st-entry: Inherit all colors pretty sure we do want this; can you check if any simplifications can be made to the CSS as a result?
Attachment 182332 [details] pushed as f524138 - st-entry: Support a different color for selected text Attachment 191568 [details] pushed as 5cb43b6 - theme: Add selected text color Attachment 191569 [details] pushed as a007b1b - st-entry: Inherit all colors I briefly looked and it seemed there wasn't any place that was ugly because of this.
St.Entry loses selection when lost focus. Impossible add a popup menu for action "Copy".