Bug 643693 – Crash opening attached text/html mail

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 643693 - Crash opening attached text/html mail


Summary:	Crash opening attached text/html mail


Status:	RESOLVED FIXED

Product:	evolution
Classification:	Applications
Component:	Mailer
Version:	2.32.x (obsolete)
Hardware:	Other Linux

Importance:	High critical
Target Milestone:	---
Assigned To:	evolution-mail-maintainers
QA Contact:	Evolution QA team

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2011-03-02 17:27 UTC by below
Modified:	2011-03-04 13:01 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Spamassassin output with attached "Romanian Business Newletter" (53.78 KB, application/mbox) 2011-03-02 17:27 UTC, below		Details
GDB stack trace (from core file) (324.86 KB, application/x-zip-compressed) 2011-03-02 18:58 UTC, below		Details
evo patch (1.07 KB, patch) 2011-03-04 13:00 UTC, Milan Crha	committed	Details \| Review

Description below 2011-03-02 17:27:58 UTC

Created attachment 182277 [details]
Spamassassin output with attached "Romanian Business Newletter"

I am filtering my mail with Spamassassin, which attaches the original mail to the filter results. When trying to open the original mail in the attached message, Evolution crashes with a segmentation fault and the message below. The original mail seems to be a more or less normal HTML spam mail.


(evolution:19481): GLib-GObject-CRITICAL **: Object class EMFolderTree doesn't implement property 'paste-target-list' from interface 'ESelectable'

(evolution:19481): GLib-GObject-CRITICAL **: Object class EMFolderTree doesn't implement property 'copy-target-list' from interface 'ESelectable'

Comment 1 Matthew Barnes 2011-03-02 17:32:40 UTC

Thanks for taking the time to report this bug.
Without a stack trace from the crash it's very hard to determine what caused it.
Can you get us a stack trace? Please see http://live.gnome.org/GettingTraces for more information on how to do so. Thanks in advance!

Comment 2 below 2011-03-02 18:58:48 UTC

Created attachment 182289 [details]
GDB stack trace (from core file)

Looks like a loop of these lines, I stopped it after #80000

+ Trace 226171

#80561 em_format_part
at em-format.c line 870
#80562 make_part_attachment
at prefer-plain.c line 71
#80563 emfh_format_format
at em-format-hook.c line 79
#80564 em_format_part_as
at em-format.c line 839
#80565 em_format_part
at em-format.c line 870
#80566 make_part_attachment
at prefer-plain.c line 71
#80567 emfh_format_format
at em-format-hook.c line 79

Comment 3 Milan Crha 2011-03-04 09:50:41 UTC

Confirming, I can reproduce it too, with your test message, if I set in Edit->Preferences->Mail Preferences, tag HTML Messages to:
   [x] Show suppressed HTML parts as attachments
   HTML Mode [ Only ever show plaintext | v ]
and I expand the email attachment. Turning off "Show suppressed HTML parts as attachments" results in no crash.

Comment 4 Milan Crha 2011-03-04 13:00:42 UTC

Created attachment 182457 [details] [review]
evo patch

for evolution;

The attached message (the inner one) was text/html part, which confused formatting machinery enough to stack overflow due to prefer-plain plugin. This change passes inner content as mime part, not mime message, which fixes the issue.

Comment 5 Milan Crha 2011-03-04 13:01:57 UTC

Created commit f1710c9 in evo master (2.91.91+)