After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643667 - totem_pl_parser_line_is_empty checks for empty lines but lets NULL through
totem_pl_parser_line_is_empty checks for empty lines but lets NULL through
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-02 13:54 UTC by Philip Van Hoof
Modified: 2011-03-02 15:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Playlist that crashes the library (1 bytes, audio/x-scpls)
2011-03-02 13:54 UTC, Philip Van Hoof 		  Details
Mini program that illustrates the problem (747 bytes, text/x-csrc)
2011-03-02 13:55 UTC, Philip Van Hoof 		  Details
Patch that fixes it (486 bytes, patch)
2011-03-02 13:55 UTC, Philip Van Hoof 		committed Details | Review

Description Philip Van Hoof 2011-03-02 13:54:42 UTC 
Created attachment 182249 [details]
Playlist that crashes the library

This causes a bug in totem_pl_parser_add_pls_with_contents

I will attach a test file that fails (segfault), a mini-example to illustrate and a patch that fixes this
Comment 1 Philip Van Hoof 2011-03-02 13:55:03 UTC 
Created attachment 182250 [details]
Mini program that illustrates the problem
Comment 2 Philip Van Hoof 2011-03-02 13:55:21 UTC 
Created attachment 182251 [details] [review]
Patch that fixes it
Comment 3 Bastien Nocera 2011-03-02 15:00:20 UTC 
Please attach patches in git format in the future, so I don't have to
commit it by hand. There's also no need to create yet another test program
we already have a test suite, I just added the couple of lines of code
to plparse/tests/parser.c to try and parse the empty playlist instead.