After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643471 - fpsdisplaysink: fix default sync property value
fpsdisplaysink: fix default sync property value
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.22
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-28 10:55 UTC by Benjamin Gaignard
Modified: 2011-03-03 08:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
set sync property to true (1.56 KB, patch)
2011-02-28 10:55 UTC, Benjamin Gaignard 		committed Details | Review

Description Benjamin Gaignard 2011-02-28 10:55:20 UTC 
Created attachment 182083 [details] [review]
set sync property to true 

the default value of sync property is not well set default is true and current is false. Set both to true
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2011-03-03 08:20:39 UTC 
Thanks!

commit 588db0bf51122fe4fb17a98b5dfa95eb8e897693
Author: benjamin gaignard <benjamin.gaignard@linaro.org>
Date:   Mon Feb 28 11:51:54 2011 +0100

    fpsdisplay: fix sync property default value
Comment 2 Tim-Philipp Müller 2011-03-03 08:49:50 UTC 
This changes the default behaviour from sync=false to sync=true, is that intentional?

Stefan: please git commit --amend commits and add the bug number/URI when you push patches that don't have that info in the commit message yet.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2011-03-03 08:56:32 UTC 
(In reply to comment #2)
> This changes the default behaviour from sync=false to sync=true, is that
> intentional?

I'd say so. Sync=false would meassure the raw decoding fps (no drops). I will add more explanation to the docs.

> 
> Stefan: please git commit --amend commits and add the bug number/URI when you
> push patches that don't have that info in the commit message yet.

Right, sorry.