After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643371 - Use standard GObject Introspection compilation
Use standard GObject Introspection compilation
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: building
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Colin Walters
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-26 17:36 UTC by Giovanni Campagna
Modified: 2011-03-01 22:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use standard GObject Introspection make rules (7.64 KB, patch)
2011-02-26 17:36 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2011-02-26 17:36:23 UTC 
See patch
Comment 1 Giovanni Campagna 2011-02-26 17:36:52 UTC 
Created attachment 181997 [details] [review]
Use standard GObject Introspection make rules

Instead of defining rules manually, use the included make support,
which means Makefiles are less prone to API changes, support
verbosity correctly (instead of inconsistently hardcoding --quiet),
are cleaner to read, and emit GISCAN/GICOMP instead of GEN (which
is nicer).
Comment 2 Colin Walters 2011-03-01 21:59:10 UTC 
Review of attachment 181997 [details] [review]:

Obviously a ton of small details here, but I didn't see anything wrong when looking through most of it.  Let's go with it; thanks for the patch!
Comment 3 Giovanni Campagna 2011-03-01 22:04:11 UTC 
Attachment 181997 [details] pushed as 6e3c15e - Use standard GObject Introspection make rules