GNOME Bugzilla – Bug 642939
deprecation warning from some script-fu scripts
Last modified: 2011-11-09 18:03:45 UTC
Created attachment 181553 [details] [review] alpha selection to item selection, drawable perspective transform to item plug-ins/script-fu/scripts/drop-shadow.scm plug-ins/script-fu/scripts/perspective-shadow.scm plug-ins/script-fu/scripts/xach-effect.scm In gimp-2.7.2 these scripts function but give warnings that some procedures they use have been deprecated. The deprecated warnings should be removed. There should be a patch attached which accomplishes this.
Created attachment 181580 [details] [review] Fix error in camouflage plugin Fixes an error in camouflage plugin, plus the usage of some deprecated procedures
Created attachment 181581 [details] [review] Updates the usage of deprecated gimp-image-add-layer Replaces the usage of the deprecated gimp-image-add-layer by gimp-image-insert-layer in plugins Applies on top of 0001-Fix-some-errors-and-usage-of-deprecated-procedures.patch
Created attachment 181677 [details] [review] deprecated removed, contexts set and a few miscelaneous repairs This patch should update most of the logo scripts including the new context settings. Chalk was broke, kinda (the background was merged and cleared leaving a silly option in the dialog) and with this patch, it isn't. Brush updates not included with this patch.
commit 403630fd5799c68cad1330289d457ea8f5f7ed47 Author: Kevin Cozens <kcozens@cvs.gnome.org> Date: Wed Mar 2 02:21:50 2011 -0500 Applied modified version of first patch for bug #642939. Original patch supplied by Nelson A. de Oliveira. Modified to not use the -1 "insanity" for invalid/none layer ID's in scripts per IRC discussion. commit b435e55d14a5d21aa533e479838441d584b828f0 Author: Kevin Cozens <kcozens@cvs.gnome.org> Date: Wed Mar 2 02:55:43 2011 -0500 Applied modified version of second patch for bug #642939. Original patch supplied by Nelson A. de Oliveira. Modified to not use the -1 "insanity" for invalid/none layer ID's in scripts per IRC discussion. Additional scripts were changed to not pass -1 to gimp-image-insert-layer.
Review of attachment 181580 [details] [review]: Patch was commited with minor changes.
Review of attachment 181581 [details] [review]: Patch was commited with minor changes.
Review of attachment 181677 [details] [review]: Used parts of the patch which protected against changes in global context.
The Script-Fu scripts have been updated to remove the use of deprecated procedures.
Relevant commits are: commit 27bef34bd550320706b90a4fa29130c7022b2111 Author: Kevin Cozens <kcozens@svn.gnome.org> Date: Wed Nov 9 02:42:34 2011 -0500 Don't change global context and protect scripts from global context settings. commit 05d4e788300a3a796e4b1b85b5871bad91c1e6f7 Author: Alexis Wilhelm <alexiswilhelm@gmail.com> Date: Sat Nov 5 20:13:02 2011 +0100 Removed use of deprecated functions in two Script-Fu scripts (bug #647834) commit 176773dcfe07e15c38d8a7802353d4603d75c9c6 Author: Kevin Cozens <kcozens@svn.gnome.org> Date: Sun Nov 6 15:55:45 2011 -0500 Second stage in removing use of deprecated functions in Script-Fu scripts Applied most of the mega patch from br0cc0li (see bug #647834) with additional de-tabbing and changes in whitespace. commit 0bd1c2f09f54359d192e190467b06bb6deea8e66 Author: Kevin Cozens <kcozens@svn.gnome.org> Date: Thu Nov 3 22:29:49 2011 -0400 Fix previous script-fu deprecation commit due to overzealous update script. commit 5e015aebbaaa663d03cc6f47a58cbeaf56b08418 Author: Kevin Cozens <kcozens@svn.gnome.org> Date: Sun Oct 30 02:37:26 2011 -0400 First stage in removing use of deprecated functions in Script-Fu scripts This commit replaces the names of deprecated procedures with the name of the new procedure where the new procedure takes the same argument list.