After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642895 - Don't show trash icon in dash when dragging a window of a favorite application
Don't show trash icon in dash when dragging a window of a favorite application
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-21 18:50 UTC by Fabio Berta
Modified: 2011-05-25 20:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dash: during drag, only offer trash can when dragging favorites (1.23 KB, patch)
2011-05-03 17:24 UTC, Owen Taylor 		committed Details | Review

Description Fabio Berta 2011-02-21 18:50:46 UTC 
Right now, when dragging a window of a favorite application in the overview, the trash icon gets shown in the dash. Now this seems strange to me. It kinda gives the impression that the window gets closed and not that the application gets removed from favorites. 
So my suggestion would be to only show the trash icon when dragging the application icon in the dash.
Comment 1 Owen Taylor 2011-05-03 17:24:15 UTC 
Created attachment 187134 [details] [review]
dash: during drag, only offer trash can when dragging favorites

We should only show the trash can when the user starts dragging a
favorite from the dash, not when the user starts dragging an application
that happens to be a favorite via a window or an application icon
in the applications view.
Comment 2 Florian Müllner 2011-05-03 18:48:13 UTC 
Review of attachment 187134 [details] [review]:

Code looks good. The change makes sense to me, but designer approval before committing might be a good idea nonetheless ...
Comment 3 Lapo Calamandrei 2011-05-11 13:47:06 UTC 
Makes sense.
Comment 4 Owen Taylor 2011-05-25 20:43:40 UTC 
Attachment 187134 [details] pushed as 019670b - dash: during drag, only offer trash can when dragging favorites