After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642813 - [PATCH] Fix small freezes when moving window
[PATCH] Fix small freezes when moving window
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
2.30.x
Other All
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-20 15:02 UTC by Vincent Untz
Modified: 2011-04-07 12:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix small freezes when moving window (2.18 KB, patch)
2011-02-20 15:02 UTC, Vincent Untz 		none Details | Review
Fix small freezes when moving window (3.56 KB, patch)
2011-02-20 15:31 UTC, Vincent Untz 		none Details | Review

Description Vincent Untz 2011-02-20 15:02:00 UTC 
This is for gnome-2-30.

This is happening because we synchronously save a file, with a fsync() call. And that hits us really hard when a window is moved because we do that several times.
Comment 1 Vincent Untz 2011-02-20 15:02:03 UTC 
Created attachment 181411 [details] [review]
Fix small freezes when moving window

This is similar to ce9025ff: we only save the window size after a
timeout, to stop always saving a file which calls fsync() and is
therefore slow.
Comment 2 Vincent Untz 2011-02-20 15:31:07 UTC 
Created attachment 181412 [details] [review]
Fix small freezes when moving window

This is similar to ce9025ff: we only save the window size after a
timeout, to stop always saving a file which calls fsync() and is
therefore slow.

We also don't save the size if it hasn't changed.
Comment 3 Shaun McCance 2011-04-07 12:52:18 UTC 
Fixed in 3.0