After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642810 - [PATCH] Patch for gcc warnings
[PATCH] Patch for gcc warnings
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-20 14:21 UTC by Kjartan Maraas
Modified: 2011-03-02 18:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for warnings (6.22 KB, patch)
2011-02-20 14:21 UTC, Kjartan Maraas 		needs-work Details | Review
patch for datetime (2.24 KB, patch)
2011-02-21 18:00 UTC, Kjartan Maraas 		committed Details | Review
patch for display panel (6.78 KB, patch)
2011-02-21 18:01 UTC, Kjartan Maraas 		reviewed Details | Review
patch for media panel (458 bytes, patch)
2011-02-21 18:01 UTC, Kjartan Maraas 		committed Details | Review
patch for shell (1.29 KB, patch)
2011-02-21 18:02 UTC, Kjartan Maraas 		committed Details | Review

Description Kjartan Maraas 2011-02-20 14:21:30 UTC 
Created attachment 181407 [details] [review]
patch for warnings

attached...
Comment 1 Bastien Nocera 2011-02-20 19:02:42 UTC 
Review of attachment 181407 [details] [review]:

Could you please split the patch, one commit per panel, for example:
"display: Fix warnings from GCC 4.6"

::: panels/datetime/tz.c
@@ +197,3 @@
 tz_location_set_locally (TzLocation *loc)
 {
+#if 0

Just remove the code.

::: panels/display/xrandr-capplet.c
@@ +680,2 @@
   gboolean sensitive;
+#endif

Just remove that code.

::: panels/info/cc-info-panel.c
@@ -352,2 @@
 static gboolean
-get_is_graphics_accelerated (void)

Nope, that's going to be used soon.
Comment 2 Kjartan Maraas 2011-02-21 17:01:11 UTC 
Should I just remove the correction variable in tz_location_set_locally() and make the function void? It's just returning 0 always now...
Comment 3 Kjartan Maraas 2011-02-21 17:03:48 UTC 
Or maybe remove the whole function since it's not used in any file in datetime.
Comment 4 Bastien Nocera 2011-02-21 17:07:47 UTC 
Let's remove the whole thing if it's not working as expected.
Comment 5 Kjartan Maraas 2011-02-21 18:00:40 UTC 
Created attachment 181496 [details] [review]
patch for datetime
Comment 6 Kjartan Maraas 2011-02-21 18:01:07 UTC 
Created attachment 181497 [details] [review]
patch for display panel
Comment 7 Kjartan Maraas 2011-02-21 18:01:39 UTC 
Created attachment 181498 [details] [review]
patch for media panel
Comment 8 Kjartan Maraas 2011-02-21 18:02:37 UTC 
Created attachment 181499 [details] [review]
patch for shell
Comment 9 Bastien Nocera 2011-03-02 18:05:54 UTC 
Review of attachment 181497 [details] [review]:

This patch contains far more than just the display panel changes...

Will split.