After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642753 - Power indicator says "0 minutes remaining" when estimating battery life
Power indicator says "0 minutes remaining" when estimating battery life
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-19 14:31 UTC by Milan Bouchet-Valat
Modified: 2011-03-01 19:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
PowerStatus: report 0 minutes as "Estimating..." (3.41 KB, patch)
2011-02-19 14:42 UTC, Giovanni Campagna 		none Details | Review
PowerStatus: report 0 minutes as "Estimating..." (3.18 KB, patch)
2011-02-26 16:27 UTC, Giovanni Campagna 		committed Details | Review

Description Milan Bouchet-Valat 2011-02-19 14:31:53 UTC 
When the laptop battery life hasn't been estimated yet (new install...), the power indicator menu says "0 minutes remaining". In GNOME 2, it said "Estimating...", which is more correct and explains the user why time isn't shown. I think the Shell should do the same.
Comment 1 Giovanni Campagna 2011-02-19 14:42:09 UTC 
Created attachment 181321 [details] [review]
PowerStatus: report 0 minutes as "Estimating..."

When UPower has not yet collected enough data to calculate a time
to discharge, it will report 0 minutes. Show "Estimating..." in
that case instead.
Comment 2 Milan Bouchet-Valat 2011-02-19 15:36:52 UTC 
Thanks, but you shouldn't hide percentage, since it's the only information available when estimating battery life. I don't see why we should show it in the normal case and hide it when estimating.
Comment 3 Giovanni Campagna 2011-02-26 16:27:15 UTC 
Created attachment 181993 [details] [review]
PowerStatus: report 0 minutes as "Estimating..."

When UPower has not yet collected enough data to calculate a time
to discharge, it will report 0 minutes. Show "Estimating..." in
that case instead.

Sorry for being late, I was not CCed to the bug and didn't see the
comment. I still hope this can be fixed despite UI freeze.
Comment 4 Owen Taylor 2011-03-01 18:56:05 UTC 
Comment on attachment 181993 [details] [review]
PowerStatus: report 0 minutes as "Estimating..."

Looks good. Only freeze that would matter for this is the string freeze.
Comment 5 Giovanni Campagna 2011-03-01 19:19:41 UTC 
Attachment 181993 [details] pushed as 89dcd90 - PowerStatus: report 0 minutes as "Estimating..."