GNOME Bugzilla – Bug 642740
[touchpad] Make the duration of the touchpad disablement after typing settable via GSettings
Last modified: 2011-03-11 20:10:18 UTC
G-S-D (via the control-panel) provides a mean to disable the touchpad inputs while typing. G-S-D communicate with syndaemon to instruct such a disablement by spawning a process with the right parameters. By default, the touchpad is disabled for 2sec after the last keypress. This default is currently hardcoded [0] but some powerusers might want to customize this value by the mean of GSettings (I am *NOT* asking for UI exposition). Also, this default value feels a bit too long. But that is purely subjective. Thanks ! [0] http://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/mouse/gsd-mouse-manager.c : line 565
Created attachment 181313 [details] [review] Make the keyboard disablement-after-timing duration a GSettings key, with default of 2.0s
+ <key name="disable-while-typing-duration" type="d"> + <default>2.0</default> You should put a <range> on that. + double keyboard_idle = g_settings_get_double (manager->priv->touchpad_settings, + KEY_TOUCHPAD_DISABLE_W_DURATION); + gchar* keyboard_idle_str = g_strdup_printf ("%1.1lf", keyboard_idle); You need to use locale-independent formatting here (g_ascii_formatd).
Created attachment 181369 [details] [review] Fixed patch Thanks for your input, Christian. Here attached a fixed patch defining a range in the schema definition and using locale-independent long-to-string conversion.
Created attachment 183138 [details] [review] Make the touchpad disablement-after-typing duration a GSettings key with a default value of 2.0s and a valid range of 0.0 - 5.0.
I still don't agree to the principle of this change. Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. *** This bug has been marked as a duplicate of bug 590783 ***
(In reply to comment #5) > I still don't agree to the principle of this change. What would be a more appropriate change to your eyes ?
(In reply to comment #6) > (In reply to comment #5) > > I still don't agree to the principle of this change. > > What would be a more appropriate change to your eyes ? I don't know, but this seems like a cop-out, not an actual fix to the problem.
(In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > I still don't agree to the principle of this change. > > > > What would be a more appropriate change to your eyes ? > > I don't know, but this seems like a cop-out, not an actual fix to the problem. Might be. Defining an heuristic to identify unwanted touchpad events migt prove challenging. Apart from cutting thumbs, i really dont see how to fix that :) A first step might be to find a saner default. 2sec is really long for most usage (touch pad of a notebook, 1-3 cm apart from the keyboard).