After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642713 - Building vinagre 2.91.7 with introspection fails
Building vinagre 2.91.7 with introspection fails
Status: RESOLVED FIXED
Product: vinagre
Classification: Applications
Component: general
2.91.x
Other Linux
: Normal blocker
: ---
Assigned To: David King
vinagre-maint
: 643259 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-02-18 20:34 UTC by Jan Alexander Steffens (heftig)
Modified: 2011-03-07 22:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Avoid NULL pointer and improve introspection build (2.95 KB, patch)
2011-02-28 03:26 UTC, Brett Witherspoon
committed Details | Review

Description Jan Alexander Steffens (heftig) 2011-02-18 20:34:56 UTC
I'm trying to build the just-released vinagre 2.91.7, but building the introspection fails with the following messages:

---

  GISCAN Vinagre-3.0.gir
pty_open.h:59: Warning: Vinagre: symbol='pty_open': Unknown namespace for symbol 'pty_open'
vinagre-plugin-dialog.h:5: Warning: Vinagre: symbol='__VINAGRE_ENUMS_H__': Unknown namespace for symbol '_VINAGRE_ENUMS_H__'
error registering vinagre typelib: Typelib file for namespace 'Vinagre', version '3.0' not found
GConf Error: Failed to contact configuration server; the most common cause is a missing or misconfigured D-Bus session bus daemon. See http://projects.gnome.org/gconf/ for information. (Details -  1: Not running within active session)
GConf Error: Failed to contact configuration server; the most common cause is a missing or misconfigured D-Bus session bus daemon. See http://projects.gnome.org/gconf/ for information. (Details -  1: Not running within active session)
Command line `dbus-launch --autolaunch=ff187c1eaec21378526662a8001b664b --binary-syntax --close-stderr' exited with non-zero exit status 1: Autolaunch error: X11 initialization failed.\nCommand '['./vinagre', '--introspect-dump=/tmp/tmp-introspectj1lgrK/types.txt,/tmp/tmp-introspectj1lgrK/dump.xml']' returned non-zero exit status 1
make[4]: *** [Vinagre-3.0.gir] Error 1

---

I believe it requires an X server during build?

For now, I'm building without introspection.
Comment 1 André Klapper 2011-02-27 19:52:12 UTC
*** Bug 643259 has been marked as a duplicate of this bug. ***
Comment 2 Brett Witherspoon 2011-02-28 03:26:16 UTC
Created attachment 182063 [details] [review]
Avoid NULL pointer and improve introspection build

There are several issues going on here that I have  also struggled with while trying to build with introspection enabled. The obvious issue is that vinagre does all its initilazation when the introspection information is dumped with --introspect-dump, so this requires a running  X session, the schemas, and a dbus session with the dconf daemon available. 

Is this aviodable? Of course the schemas will not always be installed. This is also a problem for package managers that build from source as a special user that will never be running a graphical session and the plugins do not function without introspection.

There is another issue with the introspection build even if all that is available; vinagre seg faults when no introspection information is found which is the case on initial install. I have attached a patch to avoid the NULL pointer. This seems to be a good idea anyways.

In addition I believe TelepathyGLib-0.12 needs to be included with g-ir-scanner when the plugin is enabled. I am unsure if it is correct to exclude pty_open.h and vinagre-plugin-dialog.h in the scanned files, but I don't see any introspection annotations in them so I have included that in the attached patch.
Comment 3 David King 2011-03-06 10:11:43 UTC
Comment on attachment 182063 [details] [review]
Avoid NULL pointer and improve introspection build

I pushed these as commits 8b9adf5a1573ff497e56d571f5bc9e22c39399a0 and ca72a722d084c02006cd2d90bbd33734cede777c, thanks Brett!
Comment 4 David King 2011-03-06 10:14:58 UTC
It seems that Matthias Clasen also had problems with gobject-introspection and Vinagre:

http://rotty.yi.org/irclogs/gnome/#introspection/2011-02-25/

I hit exactly the same errors. I will be overhauling the build system today, and hope to fix the remaining problems before a release tomorrow.
Comment 5 David King 2011-03-07 22:32:41 UTC
This is FIXED for me in 2.91.91, with the actual commit being 000054ef176426898619df3c82c8cb225cf2d781.