After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642483 - StEntry: remove special redundant hover tracking
StEntry: remove special redundant hover tracking
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-16 17:13 UTC by Dan Winship
Modified: 2011-02-18 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
StEntry: remove special redundant hover tracking (3.38 KB, patch)
2011-02-16 17:13 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2011-02-16 17:13:13 UTC 
For historical reasons, StEntry always did hover tracking when you had
visible hint_text, even if track_hover was FALSE. Remove that special
case, and make entries track hover just like all other widgets do.

If we actually needed to distinguish hovered-with-hint-text from
hovered-without-hint-text (which, at the moment, we don't), we could
do that by setting separate CSS for :hover and :hover:indeterminate.
Comment 1 Dan Winship 2011-02-16 17:13:15 UTC 
Created attachment 181024 [details] [review]
StEntry: remove special redundant hover tracking
Comment 2 Dan Winship 2011-02-16 17:18:27 UTC 
actually, I'm unconvinced the sync_hover() (or the code it replaced) is actually providing any value
Comment 3 Florian Müllner 2011-02-18 01:25:44 UTC 
Review of attachment 181024 [details] [review]:

Sure.
Comment 4 Dan Winship 2011-02-18 14:52:20 UTC 
Attachment 181024 [details] pushed as 1a639f0 - StEntry: remove special redundant hover tracking