After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642329 - Minor workspace fixes
Minor workspace fixes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Florian Müllner
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-14 22:15 UTC by Owen Taylor
Modified: 2011-02-20 17:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspaceThumbnail: fix stacking for newly added actors (1.07 KB, patch)
2011-02-14 22:15 UTC, Owen Taylor 		committed Details | Review
workspaceThumbnail: forbid manipulations of removed workspaces (1.65 KB, patch)
2011-02-14 22:15 UTC, Owen Taylor 		committed Details | Review
Fix cursor when dragging a window over its current workspace (1.65 KB, patch)
2011-02-14 22:15 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2011-02-14 22:15:21 UTC 
Three unrelated fixes for crashes and misbehaviors with workspaces and
workspace thumbnails.
Comment 1 Owen Taylor 2011-02-14 22:15:23 UTC 
Created attachment 180859 [details] [review]
workspaceThumbnail: fix stacking for newly added actors

We don't necessarily get a syncStacking call when an actor is added
at the top of the workspace, so make sure to set the stackAbove value
for it correctly.
Comment 2 Owen Taylor 2011-02-14 22:15:26 UTC 
Created attachment 180860 [details] [review]
workspaceThumbnail: forbid manipulations of removed workspaces

Don't allow dragging onto a removed workspace or activating it.
Comment 3 Owen Taylor 2011-02-14 22:15:29 UTC 
Created attachment 180861 [details] [review]
Fix cursor when dragging a window over its current workspace

When we are dragging a window over its current workspace or workspace
thumbnail, we show show "no drop possible" feedback instead
of "move here" feedback.
Comment 4 Florian Müllner 2011-02-18 18:20:48 UTC 
Review of attachment 180859 [details] [review]:

Makes sense.
Comment 5 Florian Müllner 2011-02-18 18:21:27 UTC 
Review of attachment 180860 [details] [review]:

Looks good.
Comment 6 Florian Müllner 2011-02-18 18:22:55 UTC 
Review of attachment 180861 [details] [review]:

Makes sense.
Comment 7 Owen Taylor 2011-02-20 17:40:27 UTC 
Attachment 180859 [details] pushed as 89cc680 - workspaceThumbnail: fix stacking for newly added actors
Attachment 180860 [details] pushed as 45fe44d - workspaceThumbnail: forbid manipulations of removed workspaces
Attachment 180861 [details] pushed as 01097ac - Fix cursor when dragging a window over its current workspace