After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642303 - workspace-thumbnails: add the ability to scroll over workspaces
workspace-thumbnails: add the ability to scroll over workspaces
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 613455 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-02-14 16:56 UTC by Quentin "Sardem FF7" Glidic
Modified: 2011-02-18 17:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A simple 'scroll-event' connect then change the workspace (1.76 KB, patch)
2011-02-14 16:56 UTC, Quentin "Sardem FF7" Glidic 		needs-work Details | Review
Top-Down scroll on workspaces controls (1.54 KB, patch)
2011-02-15 09:39 UTC, Quentin "Sardem FF7" Glidic 		accepted-commit_now Details | Review
Top-Down scroll on workspaces controls (1.63 KB, patch)
2011-02-15 16:39 UTC, Quentin "Sardem FF7" Glidic 		none Details | Review
Rebased patch (1.60 KB, patch)
2011-02-18 16:55 UTC, Quentin "Sardem FF7" Glidic 		committed Details | Review

Description Quentin "Sardem FF7" Glidic 2011-02-14 16:56:40 UTC 
Created attachment 180840 [details] [review]
A simple 'scroll-event' connect then change the workspace

It can be useful to be able to scroll over the workspace thumbnails.
Comment 1 drago01 2011-02-14 18:54:19 UTC 
Review of attachment 180840 [details] [review]:

Generally looks good, some small issues though.
And you should add a commit message too not just a subject.

::: js/ui/workspacesView.js
@@ +669,3 @@
                          Lang.bind(this, this._onControlsHoverChanged));
+        controls.connect('scroll-event',
+                         Lang.bind(this, this._onMouseWheel));

I'd call this onScrollEvent to be consistent with the places where we do that.

@@ +1043,3 @@
+            Main.wm.actionMoveWorkspaceUp();
+            break;
+        case Clutter.ScrollDirection.LEFT:

Remove this case, we only have a top-down workspace layout.

@@ +1049,3 @@
+            Main.wm.actionMoveWorkspaceDown();
+            break;
+        case Clutter.ScrollDirection.RIGHT:

Same here.
Comment 2 Quentin "Sardem FF7" Glidic 2011-02-15 09:39:47 UTC 
Created attachment 180883 [details] [review]
Top-Down scroll on workspaces controls
Comment 3 drago01 2011-02-15 16:08:50 UTC 
Review of attachment 180883 [details] [review]:

Looks good, just change the commit message to something like:

workspaceThumbnails: Allow mousewheel scrolling

Allow the user to switch the active workspace by using
the mousewheel over the workspace thumbnails.
Comment 4 Dan Winship 2011-02-15 16:30:40 UTC 
*** Bug 613455 has been marked as a duplicate of this bug. ***
Comment 5 Quentin "Sardem FF7" Glidic 2011-02-15 16:39:22 UTC 
Created attachment 180914 [details] [review]
Top-Down scroll on workspaces controls

However, should wait for some thumbnails patches that might land soon then rebase on top of them as Owen said on IRC.
Comment 6 Quentin "Sardem FF7" Glidic 2011-02-18 16:55:01 UTC 
Created attachment 181237 [details] [review]
Rebased patch

A little rebase after some patches, maybe some other patches to wait for?
Comment 7 drago01 2011-02-18 17:00:08 UTC 
Review of attachment 181237 [details] [review]:

No, we should be fine now.