GNOME Bugzilla – Bug 642209
status messages show markup
Last modified: 2011-02-14 17:59:46 UTC
When someone goes "away" in an open conversation I see something like this: Jon is away. <i>(Away)</i>
Created attachment 180759 [details] [review] telepathyClient: allow pango markup in presence changes We were adding pango markup to the message in ContactManager.setPresence, but weren't correctly marking the message as containing pango markup, allowing for uglyness such as "User is <i>away</i>." being shown to the user.
Review of attachment 180759 [details] [review]: Looks good.
Comment on attachment 180759 [details] [review] telepathyClient: allow pango markup in presence changes pushed
Created attachment 180801 [details] [review] telepathyClient: Support markup in the title of presence changes Follow-up to commit 09717aae58978b2467835495e1f5d842099eaf67 so title changes also support markup instead of the ugly "<i></i>" status.
Comment on attachment 180801 [details] [review] telepathyClient: Support markup in the title of presence changes The original patch is incorrect. It will cause markup-like text in IMs to be treated as markup, when it is actually plain text. (That is, if there are <i></i>s in the body of a message, it means that the people are *talking about* markup [as in this sentence], not *using* markup.)
Comment on attachment 180801 [details] [review] telepathyClient: Support markup in the title of presence changes blah. my bad. wasn't paying attention This patch is fine, but setPresence() still has a bug in it; it needs to call GLib.markup_escape_text() on this.title too, since the user could potentially have wacky punctuation in their name
Created attachment 180842 [details] [review] telepathyClient: Support markup in the title of presence changes Follow-up to commit 09717aae58978b2467835495e1f5d842099eaf67 so title changes also support markup instead of the ugly "<i></i>" status. Additionally, make sure to escape the contact's title as that may accidentally contain unsafe markup or characters.
Attachment 180842 [details] pushed as ed6af52 - telepathyClient: Support markup in the title of presence changes