GNOME Bugzilla – Bug 642205
qtdemux: extract MusicBrainz tags
Last modified: 2011-03-08 15:32:34 UTC
Created attachment 180755 [details] [review] Patch to fix problem Any AAC encoded files which have been tagged with MusicBrainz's Picard application is not recognized by qtdemux. These tags (especially the album id) are helpful for rhythmbox to automatically download cover art. Attached is a patch which fixes the problem.
Any chance you could provide a sample file? (Or the first 500kB of a sample file?)
(In reply to comment #1) > Any chance you could provide a sample file? (Or the first 500kB of a sample > file?) I could...but they all are under copyright. Is theree a way I could make it available without running afoul of some law?
(In reply to comment #2) > (In reply to comment #1) > > Any chance you could provide a sample file? (Or the first 500kB of a sample > > file?) > > I could...but they all are under copyright. Is theree a way I could make it > available without running afoul of some law? Well, I'm just interested in the headers, not the audio, so you could try: $ head --bytes=50k foo.m4a > head.m4a or so and play with the value to see how small you can make it. A second of audio data should be fine, I doubt that violates any copyright laws. This command line should still work: $ gst-launch-0.10 -t filesrc location=head.m4a ! qtdemux ! fakesink
Or maybe you could tag one of the files here (which are Creative Commons licensed) with picard: http://gstreamer.freedesktop.org/media/dlna/strict/audio/
(In reply to comment #4) > Or maybe you could tag one of the files here (which are Creative Commons > licensed) with picard: > http://gstreamer.freedesktop.org/media/dlna/strict/audio/ OK I initially tried just truncating the files as suggested above but it appears the tags are located at the end of the file and gst-inspect couldn't parse the file until I had included almost the entire thing. I was able to tag one of the files with the creative commons license you suggested. Since they are over 1MB I can't attach it to this issue but I am making it available here: http://twix.dnsalias.net/~heath/NiN_Ghosts_I_9.m4a Let me know if you have any problems downloading it.
Works perfectly fine for me. gst-discoverer sees the tags, totem and rhythmbox do too. What are the gstreamer versions you are using and on which distribution? If you are on ubuntu, could you try the GStreamer PPA? https://launchpad.net/~gstreamer-developers/+archive/ppa
Wait, indeed the IDs where not part (that cannot be seen from the UI). Also the track had album art already so I did not noticed issues with getting the album art. Under that light, the patch makes sense.
Thanks, pushed (adapted patch a little): commit aa7e638d8ede9315c82d03a6fa1d12cd09ab5f2f Author: Heath Nielson <heathn@gmail.com> Date: Mon Feb 14 00:49:00 2011 +0000 qtdemux: extract MusicBrainz tags Extract MusicBrainz tags added by MusicBrainz's Picard tagger application. These tags (esp. the album id) are helpful for rhythmbox et.al. to automatically downloads cover art. https://bugzilla.gnome.org/show_bug.cgi?id=642205 commit 6f0a4fa85bd1983113050d397288ca4419e392fb Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Mon Feb 14 00:38:45 2011 +0000 qtdemux: refactor iTunes tag parsing a bit