After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642194 - Update calendar font styles to match mockups
Update calendar font styles to match mockups
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-12 22:02 UTC by Jonathan Strander
Modified: 2011-02-23 01:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update calendar font style (1.68 KB, patch)
2011-02-12 22:04 UTC, Jonathan Strander
none Details | Review
Update calendar font style (1.86 KB, patch)
2011-02-12 22:36 UTC, Jonathan Strander
needs-work Details | Review
Update calendar font style (2.21 KB, patch)
2011-02-16 00:58 UTC, Jonathan Strander
committed Details | Review

Description Jonathan Strander 2011-02-12 22:02:17 UTC
Noticed that there was some clarity problems with things like being able to see at a glance which days had events. Looking at the mockup here:

http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/date-n-time.png

I noticed that the coloration and some of the sizing/boldness is different than it currently is, fixing that issue.

Quick patch to follow shortly.
Comment 1 Jonathan Strander 2011-02-12 22:04:13 UTC
Created attachment 180740 [details] [review]
Update calendar font style

Now that we are using Cantrell as the default UI font, some clarity
was reduced in using the calendar. Mockups already address this so
change the font styles in CSS to match the mockups.
Comment 2 Jonathan Strander 2011-02-12 22:36:05 UTC
Created attachment 180747 [details] [review]
Update calendar font style

Missed a bold. Also misspelled Cantarell in the commit message.
Comment 3 Jakub Steiner 2011-02-14 19:07:03 UTC
Looks good to me. The very last thing will be the active day indicator (bottom border + radial gradient svg) but that has to happen everywhere else. I saw florian working on addressing that in the meantime.
Comment 4 Florian Müllner 2011-02-14 19:37:45 UTC
(In reply to comment #3)
> Looks good to me. The very last thing will be the active day indicator (bottom
> border + radial gradient svg) but that has to happen everywhere else. I saw
> florian working on addressing that in the meantime.

Yes, I have that as part of the panel style update.
Comment 5 Owen Taylor 2011-02-15 16:10:56 UTC
Review of attachment 180747 [details] [review]:

Noticed a bug when I'd tried applying this - if you have stuff under "This Week", because you moved "This week" to the right using padding on the header, you get:

   This week
Thu    11:00     Team Meeting
Comment 6 Jonathan Strander 2011-02-16 00:50:44 UTC
(In reply to comment #5)
> Review of attachment 180747 [details] [review]:
> 
> Noticed a bug when I'd tried applying this - if you have stuff under "This
> Week", because you moved "This week" to the right using padding on the header,
> you get:
> 
>    This week
> Thu    11:00     Team Meeting

I see now. I didn't have a non-all day appointment when I was testing.
Comment 7 Jonathan Strander 2011-02-16 00:58:39 UTC
Created attachment 180956 [details] [review]
Update calendar font style

This should fix the situation Owen mentioned. It -should- also align the day name with the This Week (something I just noticed in the mockup). Let me know if I broke things horribly (although it looked fine clicking around to a few different days/weeks).
Comment 8 Owen Taylor 2011-02-23 01:34:59 UTC
Alignment and padding still could use some improvement to match the mockups, but this looks good.

Attachment 180956 [details] pushed as d1eb2b2 - Update calendar font style