GNOME Bugzilla – Bug 642190
Please review string for translation
Last modified: 2017-07-22 06:00:30 UTC
This is ambiguous: http://git.gnome.org/browse/evince/tree/previewer/ev-previewer.c#n45 "Print settings file" Is "print" here a verb or a noun? Will the settings file be printed, or is it a file with settings about printing? Please provide a comment to clear things up. Thanks!
Ping?
String freeze is in a few days. Can we possibly look into this before then?
Thanks for pinging and sorry for the late reply. Here print is a noun, so it's the second. Probably we need to change the string to "Print-settings file" to avoid the ambiguity even on English?
A comment will fix it for translators (who read the comment), but if you want to change the English, what about "File with print settings". Not sure where in the GUI this is, so this might not be a good suggestion. An alternative might be "Printing settings file", but not my first choice.
The string is shown when you call the evince_preview with --help. It will show the list of options and it should contain a line like --print-settings Print settings file
Created attachment 195282 [details] [review] Suggested patch Thanks. In that case, I might propose "File specifying print settings" or my original suggestion "File with print settings". The attached patch is for the first suggestion. Ok to commit?
Wouldn't a translator comment be sufficient instead of changing the string?
It would definitely help already, but I guess the ambiguity could confuse users of the English UI as well.
Given how ambiguous the string is, I’d change it so that even users benefit from the clarification. I don’t know if the patch still applies but it looks good and is still relevant. Can this please be pushed?
Created attachment 355751 [details] [review] Patch by F Wolff, refreshed. The patch did not apply cleanly. I refreshed it.
Review of attachment 355751 [details] [review]: Looks good to me! Hopefully an evince developer is around to push that.
Comment on attachment 355751 [details] [review] Patch by F Wolff, refreshed. Pushed, thanks!