After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642115 - Remove UI code from EphySession
Remove UI code from EphySession
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-11 16:27 UTC by Alexandre Mazari
Modified: 2012-08-03 23:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Extract the session end confirmation dialog. (18.01 KB, patch)
2011-02-11 16:36 UTC, Alexandre Mazari 		rejected Details | Review
Extract the resume infobar creation code. (4.65 KB, patch)
2011-02-11 16:36 UTC, Alexandre Mazari 		rejected Details | Review
Avoid pilling two load session commands in the resume info bar response hand (832 bytes, patch)
2011-02-11 16:37 UTC, Alexandre Mazari 		rejected Details | Review
Extract resume window creation from command queue dispatcher. (3.69 KB, patch)
2011-02-11 16:37 UTC, Alexandre Mazari 		rejected Details | Review
Remove unused headers and fix a warning. (1.24 KB, patch)
2011-02-11 16:38 UTC, Alexandre Mazari 		rejected Details | Review

Description Alexandre Mazari 2011-02-11 16:27:12 UTC 
This series of patch aim at isolating and extracting the UI code found in EphySession.
The resume infobar and the session-quit dialog have been moved to their own source files.
In the longer term, some code will move to (Embed*)EphyShell/EphyWindow.
Comment 1 Alexandre Mazari 2011-02-11 16:36:12 UTC 
Created attachment 180665 [details] [review]
 Extract the session end confirmation dialog.
Comment 2 Alexandre Mazari 2011-02-11 16:36:46 UTC 
Created attachment 180666 [details] [review]
Extract the resume infobar creation code.
Comment 3 Alexandre Mazari 2011-02-11 16:37:26 UTC 
Created attachment 180667 [details] [review]
Avoid pilling two load session commands in the resume info bar response hand
Comment 4 Alexandre Mazari 2011-02-11 16:37:56 UTC 
Created attachment 180668 [details] [review]
Extract resume window creation from command queue dispatcher.
Comment 5 Alexandre Mazari 2011-02-11 16:38:44 UTC 
Created attachment 180669 [details] [review]
Remove unused headers and fix a warning.
Comment 6 Xan Lopez 2012-07-31 21:13:08 UTC 
Review of attachment 180669 [details] [review]:

This does not apply anymore (?).
Comment 7 Xan Lopez 2012-08-03 23:42:11 UTC 
Review of attachment 180665 [details] [review]:

This code is not in EphySession anymore.
Comment 8 Xan Lopez 2012-08-03 23:42:28 UTC 
Review of attachment 180666 [details] [review]:

Neither is this.
Comment 9 Xan Lopez 2012-08-03 23:43:15 UTC 
Review of attachment 180667 [details] [review]:

Neither this.
Comment 10 Xan Lopez 2012-08-03 23:44:10 UTC 
Review of attachment 180668 [details] [review]:

Neither this! :)
Comment 11 Xan Lopez 2012-08-03 23:44:42 UTC 
Thanks, not bad ideas here, but we cleaned up this code a bit (and more is coming) some time ago.